Patchwork [5,of,5] tests: drop files from exclusion list in test-check-module-imports.t

login
register
mail settings
Submitter Katsunori FUJIWARA
Date Oct. 12, 2018, 7:48 a.m.
Message ID <1536e9835ae7296c9eef.1539330527@blacknile>
Download mbox | patch
Permalink /patch/35649/
State Accepted
Headers show

Comments

Katsunori FUJIWARA - Oct. 12, 2018, 7:48 a.m.
# HG changeset patch
# User FUJIWARA Katsunori <foozy@lares.dti.ne.jp>
# Date 1538971926 -32400
#      Mon Oct 08 13:12:06 2018 +0900
# Node ID 1536e9835ae7296c9eef7938e7a2a370c55573dc
# Parent  b1f8e4aa6e384a9a08b33d67bcc809eb16dddb38
# Available At https://bitbucket.org/foozy/mercurial-wip
#              hg pull https://bitbucket.org/foozy/mercurial-wip -r 1536e9835ae7
# EXP-Topic tests-fix-import-issues
tests: drop files from exclusion list in test-check-module-imports.t

Now, these files has no style issue at checking with import-checker.py.

BTW, tests/test-imports-checker.t is still excluded, because almost
all code fragments in it has intentional importing style violation.

Using NO_CHECK_EOF instead of EOF as heredoc limit mark can make
import-checker.py ignore such fragments. But keeping these fragments
checkable seems still useful: for example, test-imports-checker.t can
be used to test whether import-checker.py can detect erroneous code
fragment in test script as expected.

Patch

diff --git a/tests/test-check-module-imports.t b/tests/test-check-module-imports.t
--- a/tests/test-check-module-imports.t
+++ b/tests/test-check-module-imports.t
@@ -29,18 +29,7 @@  outputs, which should be fixed later.
   > -X mercurial/thirdparty \
   > -X tests/hypothesishelpers.py \
   > -X tests/test-check-interfaces.py \
-  > -X tests/test-commit-interactive.t \
-  > -X tests/test-contrib-check-code.t \
   > -X tests/test-demandimport.py \
-  > -X tests/test-extension.t \
-  > -X tests/test-hghave.t \
-  > -X tests/test-hgweb-auth.py \
-  > -X tests/test-hgweb-no-path-info.t \
-  > -X tests/test-hgweb-no-request-uri.t \
-  > -X tests/test-hgweb-non-interactive.t \
-  > -X tests/test-hook.t \
-  > -X tests/test-import.t \
   > -X tests/test-imports-checker.t \
-  > -X tests/test-lock.py \
   > -X tests/test-verify-repo-operations.py \
   > | sed 's-\\-/-g' | "$PYTHON" "$import_checker" -