Patchwork [1,of,2] cleanupnodes: update comment to drop mention of filtering

login
register
mail settings
Submitter Boris Feld
Date Oct. 4, 2018, 6:21 a.m.
Message ID <8bb49aafe1d75c02f402.1538634100@localhost.localdomain>
Download mbox | patch
Permalink /patch/35439/
State Accepted
Headers show

Comments

Boris Feld - Oct. 4, 2018, 6:21 a.m.
# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 1538560787 -7200
#      Wed Oct 03 11:59:47 2018 +0200
# Node ID 8bb49aafe1d75c02f40248126969611ca78b76e8
# Parent  1a4c1a3cc3f5b54de7f56753c0ea8b02b4443958
# EXP-Topic trackfold
# Available At https://bitbucket.org/octobus/mercurial-devel/
#              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r 8bb49aafe1d7
cleanupnodes: update comment to drop mention of filtering

Since changeset 1857f50a9643 drop the filtering, we should not longer mention it
in code comment.
Yuya Nishihara - Oct. 4, 2018, 12:53 p.m.
On Thu, 04 Oct 2018 08:21:40 +0200, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld <boris.feld@octobus.net>
> # Date 1538560787 -7200
> #      Wed Oct 03 11:59:47 2018 +0200
> # Node ID 8bb49aafe1d75c02f40248126969611ca78b76e8
> # Parent  1a4c1a3cc3f5b54de7f56753c0ea8b02b4443958
> # EXP-Topic trackfold
> # Available At https://bitbucket.org/octobus/mercurial-devel/
> #              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r 8bb49aafe1d7
> cleanupnodes: update comment to drop mention of filtering

Queued, thanks.

> --- a/mercurial/scmutil.py
> +++ b/mercurial/scmutil.py
> @@ -979,7 +979,7 @@ def cleanupnodes(repo, replacements, ope
>              # unnecessary. That's the "if s or not isobs(n)" check below.
>              # Also sort the node in topology order, that might be useful for
>              # some obsstore logic.
> -            # NOTE: the filtering and sorting might belong to createmarkers.
> +            # NOTE: the sorting might belong to createmarkers.

Still it mentions the "if s or not isobs(n)" which no longer exists.

Patch

diff --git a/mercurial/scmutil.py b/mercurial/scmutil.py
--- a/mercurial/scmutil.py
+++ b/mercurial/scmutil.py
@@ -979,7 +979,7 @@  def cleanupnodes(repo, replacements, ope
             # unnecessary. That's the "if s or not isobs(n)" check below.
             # Also sort the node in topology order, that might be useful for
             # some obsstore logic.
-            # NOTE: the filtering and sorting might belong to createmarkers.
+            # NOTE: the sorting might belong to createmarkers.
             torev = unfi.changelog.rev
             sortfunc = lambda ns: torev(ns[0][0])
             rels = []