Patchwork [11,of,13] rust-chg: add Client extensions to run cHg-specific requests

login
register
mail settings
Submitter Yuya Nishihara
Date Oct. 2, 2018, 2:25 p.m.
Message ID <ac2fb97fe2c7b2bd3d9d.1538490350@mimosa>
Download mbox | patch
Permalink /patch/35317/
State Accepted
Headers show

Comments

Yuya Nishihara - Oct. 2, 2018, 2:25 p.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1537783074 -32400
#      Mon Sep 24 18:57:54 2018 +0900
# Node ID ac2fb97fe2c7b2bd3d9d5390db282620336c7912
# Parent  44246dbfc8bb8d2fd2c4beac65c82c4438eb1ef9
rust-chg: add Client extensions to run cHg-specific requests

This just provides a nicer way to issue command-server requests.

Patch

diff --git a/rust/chg/src/clientext.rs b/rust/chg/src/clientext.rs
new file mode 100644
--- /dev/null
+++ b/rust/chg/src/clientext.rs
@@ -0,0 +1,51 @@ 
+// Copyright 2018 Yuya Nishihara <yuya@tcha.org>
+//
+// This software may be used and distributed according to the terms of the
+// GNU General Public License version 2 or any later version.
+
+//! cHg extensions to command server client.
+
+use std::ffi::OsStr;
+use std::os::unix::io::AsRawFd;
+use tokio_hglib::{Client, Connection};
+
+use super::attachio::AttachIo;
+use super::message;
+use super::runcommand::ChgRunCommand;
+use super::uihandler::SystemHandler;
+
+pub trait ChgClientExt<C>
+    where C: Connection + AsRawFd,
+{
+    /// Attaches the client file descriptors to the server.
+    fn attach_io<I, O, E>(self, stdin: I, stdout: O, stderr: E) -> AttachIo<C, I, O, E>
+        where I: AsRawFd,
+              O: AsRawFd,
+              E: AsRawFd;
+
+    /// Runs the specified Mercurial command with cHg extension.
+    fn run_command_chg<I, P, H>(self, handler: H, args: I) -> ChgRunCommand<C, H>
+        where I: IntoIterator<Item = P>,
+              P: AsRef<OsStr>,
+              H: SystemHandler;
+}
+
+impl<C> ChgClientExt<C> for Client<C>
+    where C: Connection + AsRawFd,
+{
+    fn attach_io<I, O, E>(self, stdin: I, stdout: O, stderr: E) -> AttachIo<C, I, O, E>
+        where I: AsRawFd,
+              O: AsRawFd,
+              E: AsRawFd,
+    {
+        AttachIo::with_client(self, stdin, stdout, Some(stderr))
+    }
+
+    fn run_command_chg<I, P, H>(self, handler: H, args: I) -> ChgRunCommand<C, H>
+        where I: IntoIterator<Item = P>,
+              P: AsRef<OsStr>,
+              H: SystemHandler,
+    {
+        ChgRunCommand::with_client(self, handler, message::pack_args_os(args))
+    }
+}
diff --git a/rust/chg/src/lib.rs b/rust/chg/src/lib.rs
--- a/rust/chg/src/lib.rs
+++ b/rust/chg/src/lib.rs
@@ -11,11 +11,13 @@  extern crate tokio;
 extern crate tokio_hglib;
 extern crate tokio_process;
 
-pub mod attachio;
+mod attachio;
+mod clientext;
 pub mod locator;
 pub mod message;
 pub mod procutil;
-pub mod runcommand;
+mod runcommand;
 mod uihandler;
 
+pub use clientext::ChgClientExt;
 pub use uihandler::{ChgUiHandler, SystemHandler};