Patchwork [2,of,2,V2] run-tests: convert the remaining os.system() call to Unicode

login
register
mail settings
Submitter Matt Harbison
Date Sept. 17, 2018, 5:15 a.m.
Message ID <b2b5116fbe990c793e76.1537161317@Envy>
Download mbox | patch
Permalink /patch/34726/
State Accepted
Headers show

Comments

Matt Harbison - Sept. 17, 2018, 5:15 a.m.
# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1537153985 14400
#      Sun Sep 16 23:13:05 2018 -0400
# Node ID b2b5116fbe990c793e765879c3f7fb9575394ec8
# Parent  91531f9754a5f032fa635dc506091f23519bfdc3
run-tests: convert the remaining os.system() call to Unicode

I wasn't able to hit this path in 543a788eea2d, but I have now when I
accidentally left off `--local`.

Patch

diff --git a/tests/run-tests.py b/tests/run-tests.py
--- a/tests/run-tests.py
+++ b/tests/run-tests.py
@@ -2976,7 +2976,7 @@  class TestRunner(object):
         makedirs(self._bindir)
 
         vlog("# Running", cmd)
-        if os.system(cmd) == 0:
+        if os.system(_strpath(cmd)) == 0:
             if not self.options.verbose:
                 try:
                     os.remove(installerrs)