Patchwork [2,of,5] journal: inline formatted nodes and date into expression

login
register
mail settings
Submitter Yuya Nishihara
Date Sept. 15, 2018, 1:54 a.m.
Message ID <3e2db5332d5559218155.1536976446@mimosa>
Download mbox | patch
Permalink /patch/34663/
State New
Headers show

Comments

Yuya Nishihara - Sept. 15, 2018, 1:54 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1535928744 -32400
#      Mon Sep 03 07:52:24 2018 +0900
# Node ID 3e2db5332d5559218155d02bd6f6d9c7fc245c08
# Parent  7fc475b38d3ab14129708dd72b7ffc37aacb7fa7
journal: inline formatted nodes and date into expression

The variable name "str" was misleading since these values aren't always
strings.

Patch

diff --git a/hgext/journal.py b/hgext/journal.py
--- a/hgext/journal.py
+++ b/hgext/journal.py
@@ -477,6 +477,8 @@  def journal(ui, repo, *args, **opts):
         name = args[0]
 
     fm = ui.formatter('journal', opts)
+    def formatnodes(nodes):
+        return fm.formatlist(map(fm.hexfunc, nodes), name='node', sep=',')
 
     if opts.get("template") != "json":
         if name is None:
@@ -491,21 +493,18 @@  def journal(ui, repo, *args, **opts):
     for count, entry in enumerate(repo.journal.filtered(name=name)):
         if count == limit:
             break
-        newhashesstr = fm.formatlist(map(fm.hexfunc, entry.newhashes),
-                                     name='node', sep=',')
-        oldhashesstr = fm.formatlist(map(fm.hexfunc, entry.oldhashes),
-                                     name='node', sep=',')
 
         fm.startitem()
-        fm.condwrite(ui.verbose, 'oldnodes', '%s -> ', oldhashesstr)
-        fm.write('newnodes', '%s', newhashesstr)
+        fm.condwrite(ui.verbose, 'oldnodes', '%s -> ',
+                     formatnodes(entry.oldhashes))
+        fm.write('newnodes', '%s', formatnodes(entry.newhashes))
         fm.condwrite(ui.verbose, 'user', ' %-8s', entry.user)
         fm.condwrite(
             opts.get('all') or name.startswith('re:'),
             'name', '  %-8s', entry.name)
 
-        timestring = fm.formatdate(entry.timestamp, '%Y-%m-%d %H:%M %1%2')
-        fm.condwrite(ui.verbose, 'date', ' %s', timestring)
+        fm.condwrite(ui.verbose, 'date', ' %s',
+                     fm.formatdate(entry.timestamp, '%Y-%m-%d %H:%M %1%2'))
         fm.write('command', '  %s\n', entry.command)
 
         if opts.get("commits"):