Submitter | Bradley M. Jones |
---|---|
Date | Sept. 7, 2018, 2:07 a.m. |
Message ID | <trinity-e6c21f7b-7a6b-457d-bfee-4285a82ce1b2-1536286077754@3c-app-mailcom-bs12> |
Download | mbox | patch |
Permalink | /patch/34443/ |
State | Changes Requested |
Headers | show |
Comments
(+smf - this is for the website) > On Sep 6, 2018, at 22:07, Bradley M. Jones <brdjns@gmx.us> wrote: > > # HG changeset patch > # User Bradley Jones <brdjns@gmx.us> > # Date 1536285273 -43200 > # Fri Sep 07 13:54:33 2018 +1200 > # Node ID 4a6711700f7fb592b18164f1032fabb7c10480ec > # Parent ddff2dfaa572d7b5da7c412da521c793fe57518a > about: update URLs and prefer https:// This looks good to me, but I don't remember what the process is for pushing the website. Sean? > > The URLs for other version control systems on the 'About' page needed > updating. Although they pretty much all resolve to the right places > via redirection, it wouldn't hurt to have the links go straight to the > source anyway. > > diff -r ddff2dfaa572 -r 4a6711700f7f templates/about/index.html > --- a/templates/about/index.html Mon Aug 14 14:12:11 2017 +0200 > +++ b/templates/about/index.html Fri Sep 07 13:54:33 2018 +1200 > @@ -34,7 +34,7 @@ > > <h3>Similar projects</h3> > > -<p>Mercurial is used for version control of files. Similar projects include <a href="http://git-scm.org">Git</a> and <a href="http://bazaar-vcs.org">Bazaar</a>. Version control systems without a distributed architecture include <a href="http://subversion.tigris.org/">Subversion</a> and <a href="http://www.nongnu.org/cvs/">CVS</a>. > +<p>Mercurial is used for version control of files. Similar projects include <a href="https://git-scm.com">Git</a> and <a href="https://bazaar.canonical.com/en/">Bazaar</a>. Version control systems without a distributed architecture include <a href="https://subversion.apache.org">Subversion</a> and <a href="https://www.nongnu.org/cvs/">CVS</a>. > > <h3>The Website</h3> > <p>The <a href="/thepage">website</a> is a project of the Mercurial community. > _______________________________________________ > Mercurial-devel mailing list > Mercurial-devel@mercurial-scm.org > https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Augie Fackler <raf@durin42.com> writes: > (+smf - this is for the website) > >> On Sep 6, 2018, at 22:07, Bradley M. Jones <brdjns@gmx.us> wrote: >> >> # HG changeset patch >> # User Bradley Jones <brdjns@gmx.us> >> # Date 1536285273 -43200 >> # Fri Sep 07 13:54:33 2018 +1200 >> # Node ID 4a6711700f7fb592b18164f1032fabb7c10480ec >> # Parent ddff2dfaa572d7b5da7c412da521c793fe57518a >> about: update URLs and prefer https:// > > This looks good to me, but I don't remember what the process is for pushing the website. Sean? I think all I do is push to the repo? I didn't set up the deployment so I'm not exactly sure. Though, I have a small nit below: >> The URLs for other version control systems on the 'About' page needed >> updating. Although they pretty much all resolve to the right places >> via redirection, it wouldn't hurt to have the links go straight to the >> source anyway. >> >> diff -r ddff2dfaa572 -r 4a6711700f7f templates/about/index.html >> --- a/templates/about/index.html Mon Aug 14 14:12:11 2017 +0200 >> +++ b/templates/about/index.html Fri Sep 07 13:54:33 2018 +1200 >> @@ -34,7 +34,7 @@ >> >> <h3>Similar projects</h3> >> >> -<p>Mercurial is used for version control of files. Similar projects include <a href="http://git-scm.org">Git</a> and <a href="http://bazaar-vcs.org">Bazaar</a>. Version control systems without a distributed architecture include <a href="http://subversion.tigris.org/">Subversion</a> and <a href="http://www.nongnu.org/cvs/">CVS</a>. >> +<p>Mercurial is used for version control of files. Similar projects include <a href="https://git-scm.com">Git</a> and <a href="https://bazaar.canonical.com/en/">Bazaar</a>. Version control systems without a distributed architecture include <a href="https://subversion.apache.org">Subversion</a> and <a href="https://www.nongnu.org/cvs/">CVS</a>. For the redirection to urls with ending with "/en" don't we want to leave that off in general since (for example) bazaar.canonical.com will redirect based on the browser's language setting? I can fix in flight so you don't have to resend but I wanted to make sure I'm not overlooking something.
Sean Farley <sean@farley.io> writes: > Augie Fackler <raf@durin42.com> writes: > >> (+smf - this is for the website) >> >>> On Sep 6, 2018, at 22:07, Bradley M. Jones <brdjns@gmx.us> wrote: >>> >>> # HG changeset patch >>> # User Bradley Jones <brdjns@gmx.us> >>> # Date 1536285273 -43200 >>> # Fri Sep 07 13:54:33 2018 +1200 >>> # Node ID 4a6711700f7fb592b18164f1032fabb7c10480ec >>> # Parent ddff2dfaa572d7b5da7c412da521c793fe57518a >>> about: update URLs and prefer https:// >> >> This looks good to me, but I don't remember what the process is for pushing the website. Sean? > > I think all I do is push to the repo? I didn't set up the deployment so > I'm not exactly sure. Though, I have a small nit below: > >>> The URLs for other version control systems on the 'About' page needed >>> updating. Although they pretty much all resolve to the right places >>> via redirection, it wouldn't hurt to have the links go straight to the >>> source anyway. >>> >>> diff -r ddff2dfaa572 -r 4a6711700f7f templates/about/index.html >>> --- a/templates/about/index.html Mon Aug 14 14:12:11 2017 +0200 >>> +++ b/templates/about/index.html Fri Sep 07 13:54:33 2018 +1200 >>> @@ -34,7 +34,7 @@ >>> >>> <h3>Similar projects</h3> >>> >>> -<p>Mercurial is used for version control of files. Similar projects include <a href="http://git-scm.org">Git</a> and <a href="http://bazaar-vcs.org">Bazaar</a>. Version control systems without a distributed architecture include <a href="http://subversion.tigris.org/">Subversion</a> and <a href="http://www.nongnu.org/cvs/">CVS</a>. >>> +<p>Mercurial is used for version control of files. Similar projects include <a href="https://git-scm.com">Git</a> and <a href="https://bazaar.canonical.com/en/">Bazaar</a>. Version control systems without a distributed architecture include <a href="https://subversion.apache.org">Subversion</a> and <a href="https://www.nongnu.org/cvs/">CVS</a>. > > For the redirection to urls with ending with "/en" don't we want to > leave that off in general since (for example) bazaar.canonical.com will > redirect based on the browser's language setting? I can fix in flight so > you don't have to resend but I wanted to make sure I'm not overlooking > something. I've queued this without the "/en" since I haven't heard back. Will push shortly.
Patch
diff -r ddff2dfaa572 -r 4a6711700f7f templates/about/index.html --- a/templates/about/index.html Mon Aug 14 14:12:11 2017 +0200 +++ b/templates/about/index.html Fri Sep 07 13:54:33 2018 +1200 @@ -34,7 +34,7 @@ <h3>Similar projects</h3> -<p>Mercurial is used for version control of files. Similar projects include <a href="http://git-scm.org">Git</a> and <a href="http://bazaar-vcs.org">Bazaar</a>. Version control systems without a distributed architecture include <a href="http://subversion.tigris.org/">Subversion</a> and <a href="http://www.nongnu.org/cvs/">CVS</a>. +<p>Mercurial is used for version control of files. Similar projects include <a href="https://git-scm.com">Git</a> and <a href="https://bazaar.canonical.com/en/">Bazaar</a>. Version control systems without a distributed architecture include <a href="https://subversion.apache.org">Subversion</a> and <a href="https://www.nongnu.org/cvs/">CVS</a>. <h3>The Website</h3> <p>The <a href="/thepage">website</a> is a project of the Mercurial community.