Patchwork [2,of,2] tests: disable test-nointerrupt on Windows

login
register
mail settings
Submitter Matt Harbison
Date Sept. 8, 2018, 4:04 a.m.
Message ID <348ed11ba7406045a33d.1536379482@Envy>
Download mbox | patch
Permalink /patch/34412/
State Accepted
Headers show

Comments

Matt Harbison - Sept. 8, 2018, 4:04 a.m.
# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1536378882 14400
#      Fri Sep 07 23:54:42 2018 -0400
# Node ID 348ed11ba7406045a33d2e99834a341dfad6f57a
# Parent  cf6130dd324b0eed4c902b45df503be429fe413f
tests: disable test-nointerrupt on Windows

Per the followup discussion[1].  proc.send_signal(INT) in timeout.py raises a
ValueError because of an unsupported signal.  I don't like missing test coverage
for this on Windows.  But this is the last test failing on Windows, and red all
the time hides new failures.

[1] https://phab.mercurial-scm.org/D3716

Patch

diff --git a/tests/test-nointerrupt.t b/tests/test-nointerrupt.t
--- a/tests/test-nointerrupt.t
+++ b/tests/test-nointerrupt.t
@@ -1,3 +1,5 @@ 
+#require no-windows
+
 Dummy extension simulating unsafe long running command
   $ cat > sleepext.py <<EOF
   > import itertools