Patchwork tests: for consistent output flush between writing sterr and stdout

login
register
mail settings
Submitter Simon Heimberg
Date Feb. 3, 2014, 7:06 p.m.
Message ID <7c590c5589362e148524.1391454412@lapsi.heimberg.home>
Download mbox | patch
Permalink /patch/3435/
State Accepted
Commit a82de9dc4f773422b23ed6c79472a5d55e49bf83
Headers show

Comments

Simon Heimberg - Feb. 3, 2014, 7:06 p.m.
# HG changeset patch
# User Simon Heimberg <simohe@besonet.ch>
# Date 1390872228 -3600
# Branch stable
# Node ID 7c590c5589362e148524ecac7367041eeafc33b6
# Parent  ac9c5d193237194f33382e2465c5281e05d3ef7d
tests: for consistent output flush between writing sterr and stdout

Because stdout and stderr are buffered, the order of the output is other way
around on some systems.
Mads Kiilerich - Feb. 5, 2014, 1:20 a.m.
On 02/03/2014 08:06 PM, Simon Heimberg wrote:
> # HG changeset patch
> # User Simon Heimberg <simohe@besonet.ch>
> # Date 1390872228 -3600
> # Branch stable
> # Node ID 7c590c5589362e148524ecac7367041eeafc33b6
> # Parent  ac9c5d193237194f33382e2465c5281e05d3ef7d
> tests: for consistent output flush between writing sterr and stdout
>
> Because stdout and stderr are buffered, the order of the output is other way
> around on some systems.

LGTM. It might even be a candidate for stable.

/Mads
Matt Mackall - Feb. 6, 2014, 11:29 p.m.
On Mon, 2014-02-03 at 20:06 +0100, Simon Heimberg wrote:
> # HG changeset patch
> # User Simon Heimberg <simohe@besonet.ch>
> # Date 1390872228 -3600
> # Branch stable
> # Node ID 7c590c5589362e148524ecac7367041eeafc33b6
> # Parent  ac9c5d193237194f33382e2465c5281e05d3ef7d
> tests: for consistent output flush between writing sterr and stdout

Queued for default, thanks.

Patch

diff -r ac9c5d193237 -r 7c590c558936 tests/test-debugcommands.t
--- a/tests/test-debugcommands.t	Die Jan 28 02:23:48 2014 +0100
+++ b/tests/test-debugcommands.t	Die Jan 28 02:23:48 2014 +0100
@@ -33,15 +33,16 @@ 
   >     dst('hello world')
   > def g():
   >     f()
+  >     sys.stderr.flush()
   >     debugstacktrace(skip=-5, f=sys.stdout)
   > g()
   > EOF
   $ python debugstacktrace.py
   hello world at:
-   debugstacktrace.py:7 in * (glob)
+   debugstacktrace.py:8 in * (glob)
    debugstacktrace.py:5 in g
    debugstacktrace.py:3 in f
   stacktrace at:
-   debugstacktrace.py:7 *in * (glob)
-   debugstacktrace.py:6 *in g (glob)
+   debugstacktrace.py:8 *in * (glob)
+   debugstacktrace.py:7 *in g (glob)
    */util.py:* in debugstacktrace (glob)