Patchwork [1,of,2] absorb: clarify the reason for not finding changesets to modify

login
register
mail settings
Submitter Matt Harbison
Date Sept. 5, 2018, 12:55 a.m.
Message ID <ae1442742d796285b85b.1536108955@Envy>
Download mbox | patch
Permalink /patch/34322/
State Accepted
Headers show

Comments

Matt Harbison - Sept. 5, 2018, 12:55 a.m.
# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1536108502 14400
#      Tue Sep 04 20:48:22 2018 -0400
# Node ID ae1442742d796285b85bf9e0e0159665414f0478
# Parent  ab20ee07b82df985133f4e3fa3afa2ad48516340
absorb: clarify the reason for not finding changesets to modify

I'm used to pushing to non-publishing repos, so this was the last thing I
thought to check.
Pulkit Goyal - Sept. 5, 2018, 10:38 a.m.
On Wed, Sep 5, 2018 at 3:57 AM Matt Harbison <mharbison72@gmail.com> wrote:

> # HG changeset patch
> # User Matt Harbison <matt_harbison@yahoo.com>
> # Date 1536108502 14400
> #      Tue Sep 04 20:48:22 2018 -0400
> # Node ID ae1442742d796285b85bf9e0e0159665414f0478
> # Parent  ab20ee07b82df985133f4e3fa3afa2ad48516340
> absorb: clarify the reason for not finding changesets to modify
>
> I'm used to pushing to non-publishing repos, so this was the last thing I
> thought to check.
>

Queued this series, many thanks!
Pulkit Goyal - Sept. 5, 2018, 10:49 a.m.
On Wed, Sep 5, 2018 at 1:38 PM Pulkit Goyal <7895pulkit@gmail.com> wrote:

>
>
> On Wed, Sep 5, 2018 at 3:57 AM Matt Harbison <mharbison72@gmail.com>
> wrote:
>
>> # HG changeset patch
>> # User Matt Harbison <matt_harbison@yahoo.com>
>> # Date 1536108502 14400
>> #      Tue Sep 04 20:48:22 2018 -0400
>> # Node ID ae1442742d796285b85bf9e0e0159665414f0478
>> # Parent  ab20ee07b82df985133f4e3fa3afa2ad48516340
>> absorb: clarify the reason for not finding changesets to modify
>>
>> I'm used to pushing to non-publishing repos, so this was the last thing I
>> thought to check.
>>
>
> Queued this series, many thanks!
>

test-absorb.t needs to be updated with this patch. I have pushed only the
second one.

Patch

diff --git a/hgext/absorb.py b/hgext/absorb.py
--- a/hgext/absorb.py
+++ b/hgext/absorb.py
@@ -917,7 +917,7 @@  def absorb(ui, repo, stack=None, targetc
                       'be analysed\n')
                     % limit)
     if not stack:
-        raise error.Abort(_('no changeset to change'))
+        raise error.Abort(_('no mutable changeset to change'))
     if targetctx is None: # default to working copy
         targetctx = repo[None]
     if pats is None: