Patchwork [1,of,4] test-check-py3-compat: remove false output from "python3 check-py3-compat.py"

login
register
mail settings
Submitter Yuya Nishihara
Date Sept. 1, 2018, 1:55 a.m.
Message ID <875e635c201c1d1cf1c3.1535766939@mimosa>
Download mbox | patch
Permalink /patch/34225/
State Accepted
Headers show

Comments

Yuya Nishihara - Sept. 1, 2018, 1:55 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1535764718 -32400
#      Sat Sep 01 10:18:38 2018 +0900
# Node ID 875e635c201c1d1cf1c3f8d511ed32b791e8c419
# Parent  a7e22dd31f540916e79fbf23ff9f1c5baf380c53
test-check-py3-compat: remove false output from "python3 check-py3-compat.py"

If python3 were python2, these errors would be reported, but we're running
check-py3-compat.py on Python 3 here.
Pulkit Goyal - Sept. 1, 2018, 12:29 p.m.
On Sat, Sep 1, 2018 at 7:26 AM Yuya Nishihara <yuya@tcha.org> wrote:

> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1535764718 -32400
> #      Sat Sep 01 10:18:38 2018 +0900
> # Node ID 875e635c201c1d1cf1c3f8d511ed32b791e8c419
> # Parent  a7e22dd31f540916e79fbf23ff9f1c5baf380c53
> test-check-py3-compat: remove false output from "python3
> check-py3-compat.py"
>
> If python3 were python2, these errors would be reported, but we're running
> check-py3-compat.py on Python 3 here.
>

Queued this series, many thanks!

Do you have an idea on how to fix this file failure here:
https://buildbot.mercurial-scm.org/builders/hg%20tests/builds/1917/steps/run-tests.py%20%28python%202.7.10%29/logs/stdio
.
I read about that _Py_ZeroStruct is python 2 thing and is removed on Python
3. Looks like the C files are still build using Python 2?
Yuya Nishihara - Sept. 1, 2018, 1:08 p.m.
On Sat, 1 Sep 2018 17:59:31 +0530, Pulkit Goyal wrote:
> On Sat, Sep 1, 2018 at 7:26 AM Yuya Nishihara <yuya@tcha.org> wrote:
> 
> > # HG changeset patch
> > # User Yuya Nishihara <yuya@tcha.org>
> > # Date 1535764718 -32400
> > #      Sat Sep 01 10:18:38 2018 +0900
> > # Node ID 875e635c201c1d1cf1c3f8d511ed32b791e8c419
> > # Parent  a7e22dd31f540916e79fbf23ff9f1c5baf380c53
> > test-check-py3-compat: remove false output from "python3
> > check-py3-compat.py"
> >
> > If python3 were python2, these errors would be reported, but we're running
> > check-py3-compat.py on Python 3 here.
> >
> 
> Queued this series, many thanks!
> 
> Do you have an idea on how to fix this file failure here:
> https://buildbot.mercurial-scm.org/builders/hg%20tests/builds/1917/steps/run-tests.py%20%28python%202.7.10%29/logs/stdio
> .
> I read about that _Py_ZeroStruct is python 2 thing and is removed on Python
> 3. Looks like the C files are still build using Python 2?

Looks like that. If we run setup.py with python2, py3 binaries wouldn't be
built. We'll have to enable these tests only if $PYTHON is python3.

Patch

diff --git a/tests/test-check-py3-compat.t b/tests/test-check-py3-compat.t
--- a/tests/test-check-py3-compat.t
+++ b/tests/test-check-py3-compat.t
@@ -29,20 +29,6 @@ 
   > -X mercurial/thirdparty/cbor \
   > | sed 's|\\|/|g' | xargs python3 contrib/check-py3-compat.py \
   > | sed 's/[0-9][0-9]*)$/*)/'
-  contrib/python-zstandard/setup.py not using absolute_import
-  contrib/python-zstandard/setup_zstd.py not using absolute_import
-  contrib/python-zstandard/tests/common.py not using absolute_import
-  contrib/python-zstandard/tests/test_buffer_util.py not using absolute_import
-  contrib/python-zstandard/tests/test_compressor.py not using absolute_import
-  contrib/python-zstandard/tests/test_compressor_fuzzing.py not using absolute_import
-  contrib/python-zstandard/tests/test_data_structures.py not using absolute_import
-  contrib/python-zstandard/tests/test_data_structures_fuzzing.py not using absolute_import
-  contrib/python-zstandard/tests/test_decompressor.py not using absolute_import
-  contrib/python-zstandard/tests/test_decompressor_fuzzing.py not using absolute_import
-  contrib/python-zstandard/tests/test_estimate_sizes.py not using absolute_import
-  contrib/python-zstandard/tests/test_module_attributes.py not using absolute_import
-  contrib/python-zstandard/tests/test_train_dictionary.py not using absolute_import
-  setup.py not using absolute_import
 
 #endif