| Submitter | Julien Cristau |
|---|---|
| Date | Jan. 27, 2014, 8:47 a.m. |
| Message ID | <411738417d4aea4f0868.1390812474@crater2.logilab.fr> |
| Download | mbox | patch |
| Permalink | /patch/3410/ |
| State | Accepted |
| Headers | show |
Comments
On Mon, Jan 27, 2014 at 09:47:54AM +0100, Julien Cristau wrote: > # HG changeset patch > # User Julien Cristau <julien.cristau@logilab.fr> > # Date 1390811395 -3600 > # Mon Jan 27 09:29:55 2014 +0100 > # Node ID 411738417d4aea4f086804d82068e31d2a6a690d > # Parent e738d6fe5f3ff613a4ee2c0d759eee0ee4f5c9ff > log: fix 'hidden' option > > We were passing -h, which is 'help', not 'hidden'. > > diff --git a/hglib/client.py b/hglib/client.py > --- a/hglib/client.py > +++ b/hglib/client.py > @@ -942,11 +942,11 @@ class hgclient(object): > exclude - exclude names matching the given patterns > """ > args = cmdbuilder('log', template=templates.changeset, > r=revrange, f=follow, follow_first=followfirst, > d=date, C=copies, k=keyword, removed=removed, > - m=onlymerges, u=user, b=branch, P=prune, h=hidden, > + m=onlymerges, u=user, b=branch, P=prune, hidden=hidden, > l=limit, M=nomerges, I=include, X=exclude, *files) > > out = self.rawcommand(args) > out = out.split('\0')[:-1] Can you resend those with some testing? Thanks for the contribution, What part of Logilab infra switched to the command server?
On Mon, Jan 27, 2014 at 10:53:56 +0100, Pierre-Yves David wrote: > On Mon, Jan 27, 2014 at 09:47:54AM +0100, Julien Cristau wrote: > > # HG changeset patch > > # User Julien Cristau <julien.cristau@logilab.fr> > > # Date 1390811395 -3600 > > # Mon Jan 27 09:29:55 2014 +0100 > > # Node ID 411738417d4aea4f086804d82068e31d2a6a690d > > # Parent e738d6fe5f3ff613a4ee2c0d759eee0ee4f5c9ff > > log: fix 'hidden' option > > > > We were passing -h, which is 'help', not 'hidden'. > > > > diff --git a/hglib/client.py b/hglib/client.py > > --- a/hglib/client.py > > +++ b/hglib/client.py > > @@ -942,11 +942,11 @@ class hgclient(object): > > exclude - exclude names matching the given patterns > > """ > > args = cmdbuilder('log', template=templates.changeset, > > r=revrange, f=follow, follow_first=followfirst, > > d=date, C=copies, k=keyword, removed=removed, > > - m=onlymerges, u=user, b=branch, P=prune, h=hidden, > > + m=onlymerges, u=user, b=branch, P=prune, hidden=hidden, > > l=limit, M=nomerges, I=include, X=exclude, *files) > > > > out = self.rawcommand(args) > > out = out.split('\0')[:-1] > > Can you resend those with some testing? > On their way. > Thanks for the contribution, What part of Logilab infra switched to the command > server? > None yet. Hoping to gradually move the forge over to using hglib instead of mercurial directly though. Julien
On Mon, Jan 27, 2014 at 11:11:11 +0100, Julien Cristau wrote: > On Mon, Jan 27, 2014 at 10:53:56 +0100, Pierre-Yves David wrote: > > > Thanks for the contribution, What part of Logilab infra switched to the command > > server? > > > None yet. Hoping to gradually move the forge over to using hglib > instead of mercurial directly though. > BTW speaking of hglib would it be possible to get https://pypi.python.org/pypi/python-hglib updated with a 1.1 tarball? Thanks, Julien
On Mon, Jan 27, 2014 at 12:47 PM, Julien Cristau <julien.cristau@logilab.fr> wrote: > On Mon, Jan 27, 2014 at 11:11:11 +0100, Julien Cristau wrote: > >> On Mon, Jan 27, 2014 at 10:53:56 +0100, Pierre-Yves David wrote: >> >> > Thanks for the contribution, What part of Logilab infra switched to the command >> > server? >> > >> None yet. Hoping to gradually move the forge over to using hglib >> instead of mercurial directly though. >> > BTW speaking of hglib would it be possible to get > https://pypi.python.org/pypi/python-hglib updated with a 1.1 tarball? Yes, I'll update it sometime this week.
On Tue, Jan 28, 2014 at 12:12:16 +0200, Idan Kamara wrote: > On Mon, Jan 27, 2014 at 12:47 PM, Julien Cristau > <julien.cristau@logilab.fr> wrote: > > On Mon, Jan 27, 2014 at 11:11:11 +0100, Julien Cristau wrote: > > > >> On Mon, Jan 27, 2014 at 10:53:56 +0100, Pierre-Yves David wrote: > >> > >> > Thanks for the contribution, What part of Logilab infra switched to the command > >> > server? > >> > > >> None yet. Hoping to gradually move the forge over to using hglib > >> instead of mercurial directly though. > >> > > BTW speaking of hglib would it be possible to get > > https://pypi.python.org/pypi/python-hglib updated with a 1.1 tarball? > > Yes, I'll update it sometime this week. Hi all, 1.2 was tagged on Feb 1, but pypi is still stuck at 1.0. Cheers, Julien
On Mon, Feb 10, 2014 at 4:02 PM, Julien Cristau <julien.cristau@logilab.fr> wrote: > On Tue, Jan 28, 2014 at 12:12:16 +0200, Idan Kamara wrote: > >> On Mon, Jan 27, 2014 at 12:47 PM, Julien Cristau >> <julien.cristau@logilab.fr> wrote: >> > On Mon, Jan 27, 2014 at 11:11:11 +0100, Julien Cristau wrote: >> > >> >> On Mon, Jan 27, 2014 at 10:53:56 +0100, Pierre-Yves David wrote: >> >> >> >> > Thanks for the contribution, What part of Logilab infra switched to the command >> >> > server? >> >> > >> >> None yet. Hoping to gradually move the forge over to using hglib >> >> instead of mercurial directly though. >> >> >> > BTW speaking of hglib would it be possible to get >> > https://pypi.python.org/pypi/python-hglib updated with a 1.1 tarball? >> >> Yes, I'll update it sometime this week. > > Hi all, > > 1.2 was tagged on Feb 1, but pypi is still stuck at 1.0. I just uploaded 1.2. It seems like the version isn't propagated properly: $ pip install python-hglib $ pip freeze | grep hglib python-hglib==unknown
Patch
diff --git a/hglib/client.py b/hglib/client.py --- a/hglib/client.py +++ b/hglib/client.py @@ -942,11 +942,11 @@ class hgclient(object): exclude - exclude names matching the given patterns """ args = cmdbuilder('log', template=templates.changeset, r=revrange, f=follow, follow_first=followfirst, d=date, C=copies, k=keyword, removed=removed, - m=onlymerges, u=user, b=branch, P=prune, h=hidden, + m=onlymerges, u=user, b=branch, P=prune, hidden=hidden, l=limit, M=nomerges, I=include, X=exclude, *files) out = self.rawcommand(args) out = out.split('\0')[:-1]