Patchwork [01,of,12] revlog: fix typo in 'buildtext' name

login
register
mail settings
Submitter Boris Feld
Date Aug. 18, 2018, 9:27 a.m.
Message ID <544933eed9653945bbeb.1534584436@FB-lair>
Download mbox | patch
Permalink /patch/33866/
State Accepted
Headers show

Comments

Boris Feld - Aug. 18, 2018, 9:27 a.m.
# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 1534387832 -7200
#      Thu Aug 16 04:50:32 2018 +0200
# Node ID 544933eed9653945bbeb2577fa1f6decf08dbb1f
# Parent  a98e926b2f5b2404f2255f56fa967389550a0b96
# EXP-Topic sparse-snapshot
# Available At https://bitbucket.org/octobus/mercurial-devel/
#              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r 544933eed965
revlog: fix typo in 'buildtext' name

There are no such things as 'deltacomputer._buildtext'. I'm not sure why this
code never ran, but we better fix the typo.
Augie Fackler - Aug. 20, 2018, 7:02 p.m.
On Sat, Aug 18, 2018 at 11:27:16AM +0200, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld <boris.feld@octobus.net>
> # Date 1534387832 -7200
> #      Thu Aug 16 04:50:32 2018 +0200
> # Node ID 544933eed9653945bbeb2577fa1f6decf08dbb1f
> # Parent  a98e926b2f5b2404f2255f56fa967389550a0b96
> # EXP-Topic sparse-snapshot
> # Available At https://bitbucket.org/octobus/mercurial-devel/
> #              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r 544933eed965
> revlog: fix typo in 'buildtext' name

This one appears to be queued as dbc5ead9f40f, the rest appear to be on hold.

>
> There are no such things as 'deltacomputer._buildtext'. I'm not sure why this
> code never ran, but we better fix the typo.
>
> diff --git a/mercurial/revlog.py b/mercurial/revlog.py
> --- a/mercurial/revlog.py
> +++ b/mercurial/revlog.py
> @@ -2658,7 +2658,7 @@ class revlog(object):
>          self._writeentry(transaction, ifh, dfh, entry, data, link, offset)
>
>          if alwayscache and rawtext is None:
> -            rawtext = deltacomputer._buildtext(revinfo, fh)
> +            rawtext = deltacomputer.buildtext(revinfo, fh)
>
>          if type(rawtext) == bytes: # only accept immutable objects
>              self._cache = (node, curr, rawtext)
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Patch

diff --git a/mercurial/revlog.py b/mercurial/revlog.py
--- a/mercurial/revlog.py
+++ b/mercurial/revlog.py
@@ -2658,7 +2658,7 @@  class revlog(object):
         self._writeentry(transaction, ifh, dfh, entry, data, link, offset)
 
         if alwayscache and rawtext is None:
-            rawtext = deltacomputer._buildtext(revinfo, fh)
+            rawtext = deltacomputer.buildtext(revinfo, fh)
 
         if type(rawtext) == bytes: # only accept immutable objects
             self._cache = (node, curr, rawtext)