Patchwork D4301: tests: add a directory 'knownfailures' to check in known failures

login
register
mail settings
Submitter phabricator
Date Aug. 16, 2018, 2:59 p.m.
Message ID <differential-rev-PHID-DREV-bzr22kztuznmipakvssi-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/33791/
State New
Headers show

Comments

phabricator - Aug. 16, 2018, 2:59 p.m.
pulkit created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  There are some things which everyone of us stumble upon and found out that this
  does not work. Sometimes, we hg developers know that these things does not works
  because of experience. But this does not scale well when we have a new developer
  or maybe a user who wants to see what does not work and is interested in fixing
  that.
  
  Checking in the tests about the things which don't work will help others to
  reproduce these and also helps in fixing because of functionalities
  ./run-tests.py provides.
  
  IIRC we had this thought in one of the previous sprints also to checkin some of
  the known failures.
  
  I am starting with checking in a basic test failure. But I plan to check in
  more narrow related failures which we have found.
  
  Unable to find easily what exactly broken with merges and narrow made me to
  implement this idea so that we won't have similar problem in future.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4301

AFFECTED FILES
  tests/knownfailures/test-narrow-widen.t
  tests/test-narrow-widen.t

CHANGE DETAILS




To: pulkit, durin42, #hg-reviewers
Cc: mercurial-devel
phabricator - Aug. 16, 2018, 3:07 p.m.
pulkit added a comment.


  I also think that the 'knowfailures' can serve as a good place for new contributors.
  I don't want to check-in all the failures and leave them unfixed. It's like I don't know which one I will be able to fix and I have a reproduction which can help others.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4301

To: pulkit, durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/test-narrow-widen.t b/tests/knownfailures/test-narrow-widen.t
copy from tests/test-narrow-widen.t
copy to tests/knownfailures/test-narrow-widen.t
--- a/tests/test-narrow-widen.t
+++ b/tests/knownfailures/test-narrow-widen.t
@@ -10,10 +10,6 @@ 
 
   $ hg init master
   $ cd master
-  $ cat >> .hg/hgrc <<EOF
-  > [narrow]
-  > serveellipses=True
-  > EOF
 
   $ mkdir inside
   $ echo 'inside' > inside/f