Patchwork [2,of,2] cmdutil: remove _updatecleanmsg() which is no longer used anywhere

login
register
mail settings
Submitter Yuya Nishihara
Date Aug. 12, 2018, 3:27 a.m.
Message ID <72f91934d88362792e8b.1534044420@mimosa>
Download mbox | patch
Permalink /patch/33685/
State Accepted
Headers show

Comments

Yuya Nishihara - Aug. 12, 2018, 3:27 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1533860444 -32400
#      Fri Aug 10 09:20:44 2018 +0900
# Node ID 72f91934d88362792e8b6b79ceb51e90d655364e
# Parent  365ea9b1e7f8ed5e803ea5403345afb6e219712b
cmdutil: remove _updatecleanmsg() which is no longer used anywhere
Anton Shestakov - Aug. 12, 2018, 4:57 a.m.
On Sun, 12 Aug 2018 12:27:00 +0900
Yuya Nishihara <yuya@tcha.org> wrote:

> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1533860444 -32400
> #      Fri Aug 10 09:20:44 2018 +0900
> # Node ID 72f91934d88362792e8b6b79ceb51e90d655364e
> # Parent  365ea9b1e7f8ed5e803ea5403345afb6e219712b
> cmdutil: remove _updatecleanmsg() which is no longer used anywhere

Series LGTM.
Pulkit Goyal - Aug. 12, 2018, 12:53 p.m.
On Sun, Aug 12, 2018 at 10:27 AM Anton Shestakov <av6@dwimlabs.net> wrote:

> On Sun, 12 Aug 2018 12:27:00 +0900
> Yuya Nishihara <yuya@tcha.org> wrote:
>
> > # HG changeset patch
> > # User Yuya Nishihara <yuya@tcha.org>
> > # Date 1533860444 -32400
> > #      Fri Aug 10 09:20:44 2018 +0900
> > # Node ID 72f91934d88362792e8b6b79ceb51e90d655364e
> > # Parent  365ea9b1e7f8ed5e803ea5403345afb6e219712b
> > cmdutil: remove _updatecleanmsg() which is no longer used anywhere
>
> Series LGTM.
>

Queued this series. Many thanks!

> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>

Patch

diff --git a/mercurial/cmdutil.py b/mercurial/cmdutil.py
--- a/mercurial/cmdutil.py
+++ b/mercurial/cmdutil.py
@@ -607,10 +607,6 @@  def _histeditmsg():
 def _unshelvemsg():
     return _helpmessage('hg unshelve --continue', 'hg unshelve --abort')
 
-def _updatecleanmsg(dest=None):
-    warning = _('warning: this will discard uncommitted changes')
-    return 'hg update --clean %s (%s)' % (dest or '.', warning)
-
 def _graftmsg():
     # tweakdefaults requires `update` to have a rev hence the `.`
     return _helpmessage('hg graft --continue', 'hg graft --abort')