From patchwork Wed Aug  1 20:19:51 2018
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: D4033: check-code: ban use of bare xrange()
From: phabricator <phabricator@mercurial-scm.org>
X-Patchwork-Id: 33050
Message-Id: <68537ab196370625b5a48b8e92302d1e@localhost.localdomain>
To: mercurial-devel@mercurial-scm.org
Date: Wed, 1 Aug 2018 20:19:51 +0000

This revision was automatically updated to reflect the committed changes.
Closed by commit rHG882ef6949bdc: check-code: ban use of bare xrange() (authored by indygreg, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D4033?vs=9735&id=9738

REVISION DETAIL
  https://phab.mercurial-scm.org/D4033

AFFECTED FILES
  contrib/check-code.py

CHANGE DETAILS




To: indygreg, #hg-reviewers, durin42
Cc: mercurial-devel

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -511,6 +511,7 @@
     (r'getopt\.getopt', "use pycompat.getoptb instead (py3)"),
     (r'os\.getenv', "use encoding.environ.get instead"),
     (r'os\.setenv', "modifying the environ dict is not preferred"),
+    (r'(?<!pycompat\.)xrange', "use pycompat.xrange instead (py3)"),
   ],
   # warnings
   [],