Patchwork localrepo: fix pyflakes warning for unused variable after 2888a412f0b0

login
register
mail settings
Submitter Mads Kiilerich
Date Jan. 12, 2014, 4:04 p.m.
Message ID <cc40d5a0e5f276732543.1389542690@localhost.localdomain>
Download mbox | patch
Permalink /patch/3294/
State Superseded
Headers show

Comments

Mads Kiilerich - Jan. 12, 2014, 4:04 p.m.
# HG changeset patch
# User Mads Kiilerich <madski@unity3d.com>
# Date 1389542104 -3600
#      Sun Jan 12 16:55:04 2014 +0100
# Node ID cc40d5a0e5f2767325435229cab2559bf6dd85c4
# Parent  d2704c48f4176d8cd6f21d33500820d44763585c
localrepo: fix pyflakes warning for unused variable after 2888a412f0b0

The comment as it is do not seem to apply and is removed. There should perhaps
be another comment instead.
Pierre-Yves David - Jan. 13, 2014, 6:18 a.m.
Looks good to me

I though Matt fixed it Friday. I believe the comment can be dropped.

On 01/12/2014 08:04 AM, Mads Kiilerich wrote:
> # HG changeset patch
> # User Mads Kiilerich <madski@unity3d.com>
> # Date 1389542104 -3600
> #      Sun Jan 12 16:55:04 2014 +0100
> # Node ID cc40d5a0e5f2767325435229cab2559bf6dd85c4
> # Parent  d2704c48f4176d8cd6f21d33500820d44763585c
> localrepo: fix pyflakes warning for unused variable after 2888a412f0b0
>
> The comment as it is do not seem to apply and is removed. There should perhaps
> be another comment instead.
>
> diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
> --- a/mercurial/localrepo.py
> +++ b/mercurial/localrepo.py
> @@ -1691,10 +1691,6 @@ class localrepository(object):
>                                              "changegroupsubset."))
>                   else:
>                       cg = remote.changegroupsubset(fetch, heads, 'pull')
> -                # we use unfiltered changelog here because hidden revision must
> -                # be taken in account for phase synchronization. They may
> -                # becomes public and becomes visible again.
> -                cl = self.unfiltered().changelog
>                   result = self.addchangegroup(cg, 'pull', remote.url())
>   
>               # compute target subset
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel

Patch

diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -1691,10 +1691,6 @@  class localrepository(object):
                                            "changegroupsubset."))
                 else:
                     cg = remote.changegroupsubset(fetch, heads, 'pull')
-                # we use unfiltered changelog here because hidden revision must
-                # be taken in account for phase synchronization. They may
-                # becomes public and becomes visible again.
-                cl = self.unfiltered().changelog
                 result = self.addchangegroup(cg, 'pull', remote.url())
 
             # compute target subset