Patchwork [6,of,6,V2] check-code: print debug output when an ignore pattern matches

login
register
mail settings
Submitter Simon Heimberg
Date Jan. 9, 2014, 2:52 p.m.
Message ID <5e0d279cd7a2c226016a.1389279158@lapsi.heimberg.home>
Download mbox | patch
Permalink /patch/3288/
State Accepted
Commit cc09cfea3dd4881cac9e730fa4ad3a58bf22aaf1
Headers show

Comments

Simon Heimberg - Jan. 9, 2014, 2:52 p.m.
# HG changeset patch
# User Simon Heimberg <simohe@besonet.ch>
# Date 1389130197 -3600
#      Tue Jan 07 22:29:57 2014 +0100
# Node ID 5e0d279cd7a2c226016a3102cc1d2817d8748009
# Parent  21914f89ffa474a65c557cda0858d216cf2510c2
check-code: print debug output when an ignore pattern matches
Pierre-Yves David - Jan. 9, 2014, 7:07 p.m.
This series look good to me.

On 01/09/2014 06:52 AM, Simon Heimberg wrote:
> # HG changeset patch
> # User Simon Heimberg <simohe@besonet.ch>
> # Date 1389130197 -3600
> #      Tue Jan 07 22:29:57 2014 +0100
> # Node ID 5e0d279cd7a2c226016a3102cc1d2817d8748009
> # Parent  21914f89ffa474a65c557cda0858d216cf2510c2
> check-code: print debug output when an ignore pattern matches
>
> diff -r 21914f89ffa4 -r 5e0d279cd7a2 contrib/check-code.py
> --- a/contrib/check-code.py	Tue Jan 07 22:29:51 2014 +0100
> +++ b/contrib/check-code.py	Tue Jan 07 22:29:57 2014 +0100
> @@ -496,6 +496,9 @@
>                   l = prelines[n]
>   
>                   if ignore and re.search(ignore, l, re.MULTILINE):
> +                    if debug:
> +                        print "Skipping %s for %s:%s (ignore pattern)" % (
> +                            name, f, n)
>                       continue
>                   bd = ""
>                   if blame:
Augie Fackler - Jan. 14, 2014, 2:41 p.m.
On Thu, Jan 09, 2014 at 11:07:31AM -0800, Pierre-Yves David wrote:
> This series look good to me.

Agreed. Queueing.

>
> On 01/09/2014 06:52 AM, Simon Heimberg wrote:
> ># HG changeset patch
> ># User Simon Heimberg <simohe@besonet.ch>
> ># Date 1389130197 -3600
> >#      Tue Jan 07 22:29:57 2014 +0100
> ># Node ID 5e0d279cd7a2c226016a3102cc1d2817d8748009
> ># Parent  21914f89ffa474a65c557cda0858d216cf2510c2
> >check-code: print debug output when an ignore pattern matches
> >
> >diff -r 21914f89ffa4 -r 5e0d279cd7a2 contrib/check-code.py
> >--- a/contrib/check-code.py	Tue Jan 07 22:29:51 2014 +0100
> >+++ b/contrib/check-code.py	Tue Jan 07 22:29:57 2014 +0100
> >@@ -496,6 +496,9 @@
> >                  l = prelines[n]
> >                  if ignore and re.search(ignore, l, re.MULTILINE):
> >+                    if debug:
> >+                        print "Skipping %s for %s:%s (ignore pattern)" % (
> >+                            name, f, n)
> >                      continue
> >                  bd = ""
> >                  if blame:
>

Patch

diff -r 21914f89ffa4 -r 5e0d279cd7a2 contrib/check-code.py
--- a/contrib/check-code.py	Tue Jan 07 22:29:51 2014 +0100
+++ b/contrib/check-code.py	Tue Jan 07 22:29:57 2014 +0100
@@ -496,6 +496,9 @@ 
                 l = prelines[n]
 
                 if ignore and re.search(ignore, l, re.MULTILINE):
+                    if debug:
+                        print "Skipping %s for %s:%s (ignore pattern)" % (
+                            name, f, n)
                     continue
                 bd = ""
                 if blame: