Patchwork [6,of,6] check-code: print debug output when an ignore pattern matches

login
register
mail settings
Submitter Simon Heimberg
Date Jan. 7, 2014, 9:31 p.m.
Message ID <ecc5bae03e466cdd7c49.1389130282@lapsi.heimberg.home>
Download mbox | patch
Permalink /patch/3271/
State Superseded
Commit cc09cfea3dd4881cac9e730fa4ad3a58bf22aaf1
Headers show

Comments

Simon Heimberg - Jan. 7, 2014, 9:31 p.m.
# HG changeset patch
# User Simon Heimberg <simohe@besonet.ch>
# Date 1389130197 -3600
#      Tue Jan 07 22:29:57 2014 +0100
# Node ID ecc5bae03e466cdd7c492ebaf23b33ed51fb5007
# Parent  82f553e09d5345de54812c257bdc2a819d8027e3
check-code: print debug output when an ignore pattern matches
Pierre-Yves David - Jan. 8, 2014, 8:12 a.m.
The whole series looks very good to me.

I asked a question on patch 2. That is the only small shadow to dismiss.

Patch

diff -r 82f553e09d53 -r ecc5bae03e46 contrib/check-code.py
--- a/contrib/check-code.py	Tue Jan 07 22:29:51 2014 +0100
+++ b/contrib/check-code.py	Tue Jan 07 22:29:57 2014 +0100
@@ -496,6 +496,9 @@ 
                 l = prelines[n]
 
                 if ignore and re.search(ignore, l, re.MULTILINE):
+                    if debug:
+                        print "Skipping %s for %s:%s (ignore pattern)" % (
+                            name, f, n)
                     continue
                 bd = ""
                 if blame: