Patchwork D3886: strip: improve help text for --no-backup option

login
register
mail settings
Submitter phabricator
Date July 5, 2018, 5:38 a.m.
Message ID <differential-rev-PHID-DREV-acppnwqsr4hl2bcdkrz6-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/32621/
State Superseded
Headers show

Comments

phabricator - July 5, 2018, 5:38 a.m.
khanchi97 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Help text is modified to clearly define the meaning of
  --no-backup option.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3886

AFFECTED FILES
  hgext/strip.py
  tests/test-strip.t

CHANGE DETAILS




To: khanchi97, #hg-reviewers
Cc: mercurial-devel
Yuya Nishihara - July 5, 2018, 12:55 p.m.
> -      --no-backup          no backups
> +      --no-backup          do not save backup copies of files

"copies of files" sounds like working copy files. I think it should include
the word "bundle", e.g. "do not save backup bundle".
phabricator - July 5, 2018, 1:07 p.m.
yuja added a comment.


  > - --no-backup          no backups +      --no-backup          do not save backup copies of files
  
  "copies of files" sounds like working copy files. I think it should include
  the word "bundle", e.g. "do not save backup bundle".

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3886

To: khanchi97, #hg-reviewers
Cc: yuja, mercurial-devel

Patch

diff --git a/tests/test-strip.t b/tests/test-strip.t
--- a/tests/test-strip.t
+++ b/tests/test-strip.t
@@ -719,7 +719,7 @@ 
                            revisions without this option)
    -f --force              force removal of changesets, discard uncommitted
                            changes (no backup)
-      --no-backup          no backups
+      --no-backup          do not save backup copies of files
    -k --keep               do not modify working directory during strip
    -B --bookmark VALUE [+] remove revs only reachable from given bookmark
       --mq                 operate on patch repository
diff --git a/hgext/strip.py b/hgext/strip.py
--- a/hgext/strip.py
+++ b/hgext/strip.py
@@ -103,8 +103,9 @@ 
                                'option)'), _('REV')),
           ('f', 'force', None, _('force removal of changesets, discard '
                                  'uncommitted changes (no backup)')),
-          ('', 'no-backup', None, _('no backups')),
-          ('', 'nobackup', None, _('no backups (DEPRECATED)')),
+          ('', 'no-backup', None, _('do not save backup copies of files')),
+          ('', 'nobackup', None, _('do not save backup copies of files '
+                                   '(DEPRECATED)')),
           ('n', '', None, _('ignored  (DEPRECATED)')),
           ('k', 'keep', None, _("do not modify working directory during "
                                 "strip")),