Patchwork [1,of,2] test: stop passing --quiet in a run dedicated to debug output

login
register
mail settings
Submitter Boris Feld
Date July 3, 2018, 5:49 p.m.
Message ID <d283976aa9a2b35631c7.1530640186@FB-lair>
Download mbox | patch
Permalink /patch/32593/
State Accepted
Headers show

Comments

Boris Feld - July 3, 2018, 5:49 p.m.
# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 1529431831 -3600
#      Tue Jun 19 19:10:31 2018 +0100
# Node ID d283976aa9a2b35631c749facc0290dd9ea11c30
# Parent  1cac2e8c76242e16c2da5f8e6d6efb76be592eba
# EXP-Topic earlydebug
# Available At https://bitbucket.org/octobus/mercurial-devel/
#              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r d283976aa9a2
test: stop passing --quiet in a run dedicated to debug output

The goal of the run is to display some debug output. Passing --quiet in this
case is strange.
Yuya Nishihara - July 4, 2018, 11:33 a.m.
On Tue, 03 Jul 2018 19:49:46 +0200, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld <boris.feld@octobus.net>
> # Date 1529431831 -3600
> #      Tue Jun 19 19:10:31 2018 +0100
> # Node ID d283976aa9a2b35631c749facc0290dd9ea11c30
> # Parent  1cac2e8c76242e16c2da5f8e6d6efb76be592eba
> # EXP-Topic earlydebug
> # Available At https://bitbucket.org/octobus/mercurial-devel/
> #              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r d283976aa9a2
> test: stop passing --quiet in a run dedicated to debug output

Looks good. Queued, thanks.

Patch

diff --git a/tests/test-bad-extension.t b/tests/test-bad-extension.t
--- a/tests/test-bad-extension.t
+++ b/tests/test-bad-extension.t
@@ -75,7 +75,7 @@  names of extensions failed to load can b
 show traceback for ImportError of hgext.name if debug is set
 (note that --debug option isn't applied yet when loading extensions)
 
-  $ (hg -q help help --traceback --config ui.debug=True 2>&1) \
+  $ (hg help help --traceback --config ui.debug=yes 2>&1) \
   > | grep -v '^ ' \
   > | egrep 'extension..[^p]|^Exception|Traceback|ImportError|not import'
   *** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow