Patchwork D3876: rebase: check whether the rebasestate exists or not a bit early

login
register
mail settings
Submitter phabricator
Date July 1, 2018, 8:33 p.m.
Message ID <differential-rev-PHID-DREV-venxkf5rkf4vpm7hidm3-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/32556/
State Superseded
Headers show

Comments

phabricator - July 1, 2018, 8:33 p.m.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Converted the else part into `if True` because that part will soon be under a
  except part.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3876

AFFECTED FILES
  hgext/rebase.py

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/rebase.py b/hgext/rebase.py
--- a/hgext/rebase.py
+++ b/hgext/rebase.py
@@ -227,6 +227,9 @@ 
 
     def restorestatus(self):
         """Restore a previously stored status"""
+        if not self.stateobj.exists():
+            cmdutil.wrongtooltocontinue(self.repo, _('rebase'))
+
         data = self._read()
         self.repo.ui.debug('rebase status resumed\n')
 
@@ -250,9 +253,7 @@ 
         state = {}
         destmap = {}
 
-        if not self.stateobj.exists():
-            cmdutil.wrongtooltocontinue(repo, _('rebase'))
-        else:
+        if True:
             f = repo.vfs("rebasestate")
             for i, l in enumerate(f.read().splitlines()):
                 if i == 0: