Patchwork D3843: tests: fix up some lax escaping in test-template-basic.t

login
register
mail settings
Submitter phabricator
Date June 26, 2018, 5:04 p.m.
Message ID <differential-rev-PHID-DREV-qe6kpkw5uis64xtjw6ue-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/32443/
State Superseded
Headers show

Comments

phabricator - June 26, 2018, 5:04 p.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  These misfired escapes turn into hard errors in Python 3.7, and I'd
  really rather we not work around it. We should *probably* try and find
  a way to proactively warn users about invalid escape sequences.
  
  There's one more failure of this type in this file on Python 3.7, but
  I can't figure out the issue. It'll need to be corrected in a
  follow-up.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3843

AFFECTED FILES
  tests/test-template-basic.t

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/test-template-basic.t b/tests/test-template-basic.t
--- a/tests/test-template-basic.t
+++ b/tests/test-template-basic.t
@@ -835,11 +835,11 @@ 
   -o perso-
   $ hg log -R a -r 2 --template '{sub(r"\\x6e", "-", desc)}\n'
   no person
-  $ hg log -R a -r 2 --template '{sub("n", r"\x2d", desc)}\n'
+  $ hg log -R a -r 2 --template '{sub("n", r"\\x2d", desc)}\n'
   \x2do perso\x2d
   $ hg log -R a -r 2 --template '{sub("n", "\x2d", "no perso\x6e")}\n'
   -o perso-
-  $ hg log -R a -r 2 --template '{sub("n", r"\x2d", r"no perso\x6e")}\n'
+  $ hg log -R a -r 2 --template '{sub("n", r"\\x2d", r"no perso\x6e")}\n'
   \x2do perso\x6e
 
   $ hg log -R a -r 8 --template '{files % "{file}\n"}'