Patchwork convert: don't pass --no-files to "darcs show repo" command

login
register
mail settings
Submitter Yuya Nishihara
Date June 25, 2018, 3 p.m.
Message ID <aa8c8a9346e2718dd726.1529938834@mimosa>
Download mbox | patch
Permalink /patch/32412/
State Accepted
Headers show

Comments

Yuya Nishihara - June 25, 2018, 3 p.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1529749433 -32400
#      Sat Jun 23 19:23:53 2018 +0900
# Node ID aa8c8a9346e2718dd72663c3df7ebe2c15e588d0
# Parent  b45c353ebbc7b0f5f922d58d7de77e82899175f0
convert: don't pass --no-files to "darcs show repo" command

The test fails with darcs 2.14.0 because --no-files is no longer supported.
It was removed at the patch 97973a52bf496657558412562d6fad2ee651b1e0, which
says "show repo: removed --files option, removed manual flags parsing."

As far as I can tell, --no-files was specified just for optimization, so old
darcs should work without it.
Augie Fackler - June 25, 2018, 3:10 p.m.
> On Jun 25, 2018, at 11:00, Yuya Nishihara <yuya@tcha.org> wrote:
> 
> # HG changeset patch
> # User Yuya Nishihara <yuya@tcha.org>
> # Date 1529749433 -32400
> #      Sat Jun 23 19:23:53 2018 +0900
> # Node ID aa8c8a9346e2718dd72663c3df7ebe2c15e588d0
> # Parent  b45c353ebbc7b0f5f922d58d7de77e82899175f0
> convert: don't pass --no-files to "darcs show repo" command

queued, thanks

Patch

diff --git a/hgext/convert/darcs.py b/hgext/convert/darcs.py
--- a/hgext/convert/darcs.py
+++ b/hgext/convert/darcs.py
@@ -126,8 +126,7 @@  class darcs_source(common.converter_sour
         return etree.getroot()
 
     def format(self):
-        output, status = self.run('show', 'repo', no_files=True,
-                                  repodir=self.path)
+        output, status = self.run('show', 'repo', repodir=self.path)
         self.checkexit(status)
         m = re.search(r'^\s*Format:\s*(.*)$', output, re.MULTILINE)
         if not m: