Patchwork D3825: grep: deprecates `--all` flag

login
register
mail settings
Submitter phabricator
Date June 21, 2018, 4:02 p.m.
Message ID <differential-rev-PHID-DREV-5fn4blh5htkjvyjzolho-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/32365/
State Superseded
Headers show

Comments

phabricator - June 21, 2018, 4:02 p.m.
sangeet259 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  As the name "all" is a misnomer for an option that searches on diffs of revisions,
  we are moving to `diff` flag from `all`, deprecating it in the process.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3825

AFFECTED FILES
  mercurial/commands.py

CHANGE DETAILS




To: sangeet259, #hg-reviewers
Cc: mercurial-devel
Yuya Nishihara - June 22, 2018, 11:35 a.m.
>  @command('grep',
>      [('0', 'print0', None, _('end fields with NUL')),
> -    ('', 'all', None, _('print all revisions that match')),
> +    ('', 'all', None, _('print all revisions that match (DEPRECATED)')),
>      ('', 'diff', None, _('print all revisions when the term was introduced or removed')),

This doesn't apply. Can you rebase onto the current tip?
phabricator - June 22, 2018, 11:42 a.m.
yuja added a comment.


  >   @command('grep',
  >       [('0', 'print0', None, _('end fields with NUL')),
  > 
  > - ('', 'all', None, _('print all revisions that match')), +    ('', 'all', None, _('print all revisions that match (DEPRECATED)')), ('', 'diff', None, _('print all revisions when the term was introduced or removed')),
  
  This doesn't apply. Can you rebase onto the current tip?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3825

To: sangeet259, #hg-reviewers
Cc: yuja, mercurial-devel
phabricator - June 22, 2018, 1 p.m.
pulkit added inline comments.

INLINE COMMENTS

> commands.py:2446
>      a non-match, or "+" for a non-match that becomes a match), use the
>      --diff/--all flag.
>  

Drop the mention of `--all` flag from here.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3825

To: sangeet259, #hg-reviewers
Cc: pulkit, yuja, mercurial-devel

Patch

diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -2415,7 +2415,7 @@ 
 
 @command('grep',
     [('0', 'print0', None, _('end fields with NUL')),
-    ('', 'all', None, _('print all revisions that match')),
+    ('', 'all', None, _('print all revisions that match (DEPRECATED)')),
     ('', 'diff', None, _('print all revisions when the term was introduced or removed')),
     ('a', 'text', None, _('treat all files as text')),
     ('f', 'follow', None,