Patchwork [1,of,7,V1.1,(do,not,wait,for,the,six,other,one)] phases: add a formal note that hash of secret changeset may leak out

login
register
mail settings
Submitter Pierre-Yves David
Date Dec. 20, 2013, 4:27 a.m.
Message ID <496d2181cc89482cabd5.1387513670@marginatus.fb.com>
Download mbox | patch
Permalink /patch/3217/
State Accepted
Commit b4b77909318f8cfb2ed094f85117abed52d0cff0
Headers show

Comments

Pierre-Yves David - Dec. 20, 2013, 4:27 a.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
# Date 1384705817 18000
#      Sun Nov 17 11:30:17 2013 -0500
# Node ID 496d2181cc89482cabd54c52d3ec1f20a2c89177
# Parent  6c1adf2067bb7c225f96cf253e9e228b5a7cdcf4
phases: add a formal note that hash of secret changeset may leak out

For technical reason (discovery, obsolescence marker) the hash of secret
changeset are communicated outside of your repo. We clarifie that in the help so
that people does not used hash of secret changeset as nuclear launch code.
Sean Farley - Dec. 20, 2013, 8:20 p.m.
pierre-yves.david@ens-lyon.org writes:

> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
> # Date 1384705817 18000
> #      Sun Nov 17 11:30:17 2013 -0500
> # Node ID 496d2181cc89482cabd54c52d3ec1f20a2c89177
> # Parent  6c1adf2067bb7c225f96cf253e9e228b5a7cdcf4
> phases: add a formal note that hash of secret changeset may leak out
>
> For technical reason (discovery, obsolescence marker) the hash of secret
> changeset are communicated outside of your repo. We clarifie that in the help so
> that people does not used hash of secret changeset as nuclear launch code.
>
> diff --git a/mercurial/help/phases.txt b/mercurial/help/phases.txt
> --- a/mercurial/help/phases.txt
> +++ b/mercurial/help/phases.txt
> @@ -56,10 +56,17 @@ See :hg:`help config` for more informati
>  
>  .. note::
>    Servers running older versions of Mercurial are treated as
>    publishing.
>  
> +.. note::
> +   Changesets in secret phase are not exchanged with the server. This
> +   applies to their content: file names, file contents, and changeset
> +   metadata. For technical reasons, the identifier (e.g. d825e4025e39)
> +   of the secret changeset may be communicated to the server.

The English looks alright to me.
Pierre-Yves David - Dec. 20, 2013, 8:46 p.m.
On 12/20/2013 12:20 PM, Sean Farley wrote:
> pierre-yves.david@ens-lyon.org writes:
>
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
>> # Date 1384705817 18000
>> #      Sun Nov 17 11:30:17 2013 -0500
>> # Node ID 496d2181cc89482cabd54c52d3ec1f20a2c89177
>> # Parent  6c1adf2067bb7c225f96cf253e9e228b5a7cdcf4
>> phases: add a formal note that hash of secret changeset may leak out
>>
>> For technical reason (discovery, obsolescence marker) the hash of secret
>> changeset are communicated outside of your repo. We clarifie that in the help so
>> that people does not used hash of secret changeset as nuclear launch code.
>>
>> diff --git a/mercurial/help/phases.txt b/mercurial/help/phases.txt
>> --- a/mercurial/help/phases.txt
>> +++ b/mercurial/help/phases.txt
>> @@ -56,10 +56,17 @@ See :hg:`help config` for more informati
>>
>>   .. note::
>>     Servers running older versions of Mercurial are treated as
>>     publishing.
>>
>> +.. note::
>> +   Changesets in secret phase are not exchanged with the server. This
>> +   applies to their content: file names, file contents, and changeset
>> +   metadata. For technical reasons, the identifier (e.g. d825e4025e39)
>> +   of the secret changeset may be communicated to the server.
> The English looks alright to me.

Well thats a copy paste of yours.

The 2-7 patches where not changed from V1. I did not resent them.
Matt Mackall - Jan. 18, 2014, 4:10 a.m.
On Thu, 2013-12-19 at 20:27 -0800, pierre-yves.david@ens-lyon.org wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
> # Date 1384705817 18000
> #      Sun Nov 17 11:30:17 2013 -0500
> # Node ID 496d2181cc89482cabd54c52d3ec1f20a2c89177
> # Parent  6c1adf2067bb7c225f96cf253e9e228b5a7cdcf4
> phases: add a formal note that hash of secret changeset may leak out

Queued for default, thanks.

Patch

diff --git a/mercurial/help/phases.txt b/mercurial/help/phases.txt
--- a/mercurial/help/phases.txt
+++ b/mercurial/help/phases.txt
@@ -56,10 +56,17 @@  See :hg:`help config` for more informati
 
 .. note::
   Servers running older versions of Mercurial are treated as
   publishing.
 
+.. note::
+   Changesets in secret phase are not exchanged with the server. This
+   applies to their content: file names, file contents, and changeset
+   metadata. For technical reasons, the identifier (e.g. d825e4025e39)
+   of the secret changeset may be communicated to the server.
+
+
 Examples
 ========
 
  - list changesets in draft or secret phase::