Patchwork D3720: commandserver: close server's fds explicitly from a worker

login
register
mail settings
Submitter phabricator
Date June 13, 2018, 12:37 p.m.
Message ID <4f8df4374dc592626014b020de72b003@localhost.localdomain>
Download mbox | patch
Permalink /patch/32106/
State Not Applicable
Headers show

Comments

phabricator - June 13, 2018, 12:37 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc07424ec633c: commandserver: close server&#039;s fds explicitly from a worker (authored by quark, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D3720?vs=9029&id=9042

REVISION DETAIL
  https://phab.mercurial-scm.org/D3720

AFFECTED FILES
  mercurial/commandserver.py

CHANGE DETAILS




To: quark, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/commandserver.py b/mercurial/commandserver.py
--- a/mercurial/commandserver.py
+++ b/mercurial/commandserver.py
@@ -494,6 +494,8 @@ 
                     conn.close()  # release handle in parent process
             else:
                 try:
+                    selector.close()
+                    self._sock.close()
                     self._runworker(conn)
                     conn.close()
                     os._exit(0)