Patchwork D3702: mercurial: add .t files to .editorconfig

login
register
mail settings
Submitter phabricator
Date June 7, 2018, 11:19 p.m.
Message ID <differential-rev-PHID-DREV-se44po3ri5r5qyht2ca7-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/32023/
State Superseded
Headers show

Comments

phabricator - June 7, 2018, 11:19 p.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The notable entry here prevents the stripping of trailing whitespace,
  which is important in .t tests.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3702

AFFECTED FILES
  .editorconfig

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel
phabricator - June 8, 2018, 1:08 a.m.
av6 added inline comments.

INLINE COMMENTS

> .editorconfig:17
> +indent_style = space
> +indent_size = 2
> +trim_trailing_whitespace = false

Nit: I'd sort these two lines for consistency with the two entries above, otherwise looks good.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3702

To: indygreg, #hg-reviewers
Cc: av6, mercurial-devel
phabricator - June 12, 2018, 4:57 p.m.
durin42 added inline comments.

INLINE COMMENTS

> av6 wrote in .editorconfig:17
> Nit: I'd sort these two lines for consistency with the two entries above, otherwise looks good.

queued with that fixed

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3702

To: indygreg, #hg-reviewers
Cc: durin42, av6, mercurial-devel

Patch

diff --git a/.editorconfig b/.editorconfig
--- a/.editorconfig
+++ b/.editorconfig
@@ -11,3 +11,8 @@ 
 indent_size = 8
 indent_style = tab
 trim_trailing_whitespace = true
+
+[*.t]
+indent_style = space
+indent_size = 2
+trim_trailing_whitespace = false