Submitter | Matt Harbison |
---|---|
Date | May 22, 2018, 3:17 a.m. |
Message ID | <8e4cdc86c55f579eac98.1526959031@Envy> |
Download | mbox | patch |
Permalink | /patch/31803/ |
State | Accepted |
Headers | show
Return-Path: <mercurial-devel-bounces@mercurial-scm.org> X-Original-To: patchwork@mercurial-scm.org Delivered-To: patchwork@mercurial-scm.org Received: from localhost (localhost [127.0.0.1]) by mercurial-scm.org (Postfix) with ESMTP id E036F2C298; Mon, 21 May 2018 23:17:29 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at mercurial-scm.org Received: from mercurial-scm.org ([127.0.0.1]) by localhost (mercurial-scm.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id FWhzqVdXYjjQ; Mon, 21 May 2018 23:17:29 -0400 (EDT) Received: from mercurial-scm.org (localhost [IPv6:::1]) by mercurial-scm.org (Postfix) with ESMTP id 2DB2F2C332; Mon, 21 May 2018 23:17:28 -0400 (EDT) X-Original-To: mercurial-devel@mercurial-scm.org Delivered-To: mercurial-devel@mercurial-scm.org Received: from localhost (localhost [127.0.0.1]) by mercurial-scm.org (Postfix) with ESMTP id 5012B2C332 for <mercurial-devel@mercurial-scm.org>; Mon, 21 May 2018 23:17:26 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at mercurial-scm.org Received: from mercurial-scm.org ([127.0.0.1]) by localhost (mercurial-scm.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id rDFDiUjtdIOu for <mercurial-devel@mercurial-scm.org>; Mon, 21 May 2018 23:17:26 -0400 (EDT) Received: from mail-oi0-x236.google.com (mail-oi0-x236.google.com [IPv6:2607:f8b0:4003:c06::236]) by mercurial-scm.org (Postfix) with ESMTPS id B39502C1CC for <mercurial-devel@mercurial-scm.org>; Mon, 21 May 2018 23:17:23 -0400 (EDT) Received: by mail-oi0-x236.google.com with SMTP id v2-v6so14897136oif.3 for <mercurial-devel@mercurial-scm.org>; Mon, 21 May 2018 20:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:content-transfer-encoding:subject:message-id :in-reply-to:references:user-agent:date:from:to; bh=56Ksq4iFoWiOwsISskVWHwQ/QMIZxLKDmdJYXUdQB8M=; b=mqAEp5Y7e6fteo+rCqu+8I5MNLlMQ03K0zqJyOCzOKn9Ek1WxwHQCJFj7peAxe10lz O6AQ9MOtsA8BVfi5jVVYlQCf42yWtJa4JpU7vjraQNEzbe8EP3K9XpLT4A6HVkb/D5mF sJtyfcX7sww8mFC6fFgUDNhceGXlfMWWUe+/q6Jyjt9DsM0UreZQa2ssmB1DXDIfa/A6 /9XoVwwhihV/0ixKwMEL+bwj/l42psmk1i2WsLZIIQn0FPKnAOKLx46osRuoypr/UMr+ iRJK+KUzBLUIFp5oKhrlHW26DrNvKO6uwyqxY4yRMcQNUWWS5KMh4R4sjZKOsxXxi42D mQ8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding:subject :message-id:in-reply-to:references:user-agent:date:from:to; bh=56Ksq4iFoWiOwsISskVWHwQ/QMIZxLKDmdJYXUdQB8M=; b=p7yQUqRB9mB0d+cAJIhT6Pe5vIY4966I6GPJ99+uEvWlY1ly+Fug8qZ+J4hqTgmVvm LeHa/nCF4S6Jr5hA6ELWYz4R1DXeKcI3uycGMYg0hvahLfvmY4rlShDq+KINQsjf1tcb pkM9iCW4Ndj5b5HQ9TlgVl/zigQykHVfS8adwRRysxpQ/2JwFqdJsj5tQ4SuodVhXCX1 gjEN/Y53JXOd7c806H5gtJ75OZyhHzOEIp4nd1vVHCaCOlp1iBtxAAVYTztvn4egwS4z 7ShUbphJJoExoqlKQdd+MYOkzfJRKHGDEKyF43raxuPnvCISr79wCwDLoM6GXr/oy4Y3 O47Q== X-Gm-Message-State: ALKqPwdKX/uwWLb//15HtXENMT0ualoEoENlrrC0SncmLP+MmTWQImG3 lsYy0FTmy2H6o85XGI+R9hxK9uP9 X-Google-Smtp-Source: AB8JxZpqPxiIGFx/EXQkRhmCw6TIs59JAKkm17UyaCgHfEDSCAQ4SrPrzV0ToxUPkBZszBxFseQ9KA== X-Received: by 2002:aca:5086:: with SMTP id e128-v6mr13863634oib.315.1526959042820; Mon, 21 May 2018 20:17:22 -0700 (PDT) Received: from [10.8.8.11] ([173.254.254.30]) by smtp.gmail.com with ESMTPSA id v45-v6sm9499794otf.75.2018.05.21.20.17.21 for <mercurial-devel@mercurial-scm.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 May 2018 20:17:22 -0700 (PDT) MIME-Version: 1.0 Subject: [PATCH 4 of 5] githelp: rewrite a Yoda conditional X-Mercurial-Node: 8e4cdc86c55f579eac9887bd2bd09a5867232d32 X-Mercurial-Series-Index: 4 X-Mercurial-Series-Total: 5 Message-Id: <8e4cdc86c55f579eac98.1526959031@Envy> X-Mercurial-Series-Id: <a34bed7475cc8237665a.1526959028@Envy> In-Reply-To: <a34bed7475cc8237665a.1526959028@Envy> References: <a34bed7475cc8237665a.1526959028@Envy> User-Agent: Mercurial-patchbomb/4.5.2 Date: Mon, 21 May 2018 23:17:11 -0400 From: Matt Harbison <mharbison72@gmail.com> To: mercurial-devel@mercurial-scm.org X-BeenThere: mercurial-devel@mercurial-scm.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <mercurial-devel.mercurial-scm.org> List-Unsubscribe: <https://www.mercurial-scm.org/mailman/options/mercurial-devel>, <mailto:mercurial-devel-request@mercurial-scm.org?subject=unsubscribe> List-Archive: <http://www.mercurial-scm.org/pipermail/mercurial-devel/> List-Post: <mailto:mercurial-devel@mercurial-scm.org> List-Help: <mailto:mercurial-devel-request@mercurial-scm.org?subject=help> List-Subscribe: <https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel>, <mailto:mercurial-devel-request@mercurial-scm.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org> |
Comments
Matt Harbison - May 22, 2018, 3:17 a.m.
Patch
diff --git a/hgext/githelp.py b/hgext/githelp.py --- a/hgext/githelp.py +++ b/hgext/githelp.py @@ -962,7 +962,7 @@ def svn(ui, repo, *args, **kwargs): if not args: raise error.Abort(_('missing svn command')) svncmd = args[0] - if not svncmd in gitsvncommands: + if svncmd not in gitsvncommands: raise error.Abort(_('unknown git svn command "%s"') % (svncmd)) args = args[1:]