Submitter | Matt Harbison |
---|---|
Date | May 22, 2018, 3:17 a.m. |
Message ID | <c137053c30e3a477d9f2.1526959029@Envy> |
Download | mbox | patch |
Permalink | /patch/31802/ |
State | Accepted |
Headers | show
Return-Path: <mercurial-devel-bounces@mercurial-scm.org> X-Original-To: patchwork@mercurial-scm.org Delivered-To: patchwork@mercurial-scm.org Received: from localhost (localhost [127.0.0.1]) by mercurial-scm.org (Postfix) with ESMTP id 874552C29A; Mon, 21 May 2018 23:17:28 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at mercurial-scm.org Received: from mercurial-scm.org ([127.0.0.1]) by localhost (mercurial-scm.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id EIJ8d4Rpqai8; Mon, 21 May 2018 23:17:28 -0400 (EDT) Received: from mercurial-scm.org (localhost [IPv6:::1]) by mercurial-scm.org (Postfix) with ESMTP id F0EDC2C330; Mon, 21 May 2018 23:17:25 -0400 (EDT) X-Original-To: mercurial-devel@mercurial-scm.org Delivered-To: mercurial-devel@mercurial-scm.org Received: from localhost (localhost [127.0.0.1]) by mercurial-scm.org (Postfix) with ESMTP id 10A5F2C15C for <mercurial-devel@mercurial-scm.org>; Mon, 21 May 2018 23:17:24 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at mercurial-scm.org Received: from mercurial-scm.org ([127.0.0.1]) by localhost (mercurial-scm.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6krJzEec4p3P for <mercurial-devel@mercurial-scm.org>; Mon, 21 May 2018 23:17:22 -0400 (EDT) Received: from mail-oi0-x235.google.com (mail-oi0-x235.google.com [IPv6:2607:f8b0:4003:c06::235]) by mercurial-scm.org (Postfix) with ESMTPS id 3C23C2C1B8 for <mercurial-devel@mercurial-scm.org>; Mon, 21 May 2018 23:17:21 -0400 (EDT) Received: by mail-oi0-x235.google.com with SMTP id v2-v6so14897106oif.3 for <mercurial-devel@mercurial-scm.org>; Mon, 21 May 2018 20:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:content-transfer-encoding:subject:message-id :in-reply-to:references:user-agent:date:from:to; bh=WzXdpo29bPFP1FFPLRYM99AugRtnB4pwyvL1xDVGgbU=; b=EpM/stQYVhndKTy+fuXKmhVbRJaTardOzzVzPYXGqIRU3O0iuO41LBv4PkpDeMAoOr mS3qXpxFclKwEk4FUL9pIx6wz9J9hqh45Fbbq4zUl/SQ5U6m5yECIOrtGXdJPIsOa5n5 wKMqS+j0EWTWUc9zqKdJ5s5jRfrn3ZvF02bTDsWS8XGl5khZ1Op4QhAW2in2XkcAglID fsI1SVl/Qmj38EFSOieDxoYSrjVabs/ga4wbiL7SqUo2gTvwX8PVaN7oODmE8ItreQBI 9zQ/5aJXLXllyZ2FMrymkV+Ct6B9ViURFfa9GAx97VxyaaI37DHXjAnJKKsk74R35tqV mxvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding:subject :message-id:in-reply-to:references:user-agent:date:from:to; bh=WzXdpo29bPFP1FFPLRYM99AugRtnB4pwyvL1xDVGgbU=; b=rMxcf97qaqerB7BA7y3CEBSDMuCEW0gHvWT4dyNKuVX3YcFg8b0tvvs3DPyA3sMWrf DJNcSPcKGDrg6jkNZ5kc6XeFwdpFdDL2Vi1RfYjThhlwikbdxIBJE6MLpSfhfnU/k798 Oi/B5l9xFjCY9WbJvmm5Q7Sk64+YLxzgG51E1i7piDcoPpfukIeNfaP0cUzVXEMg0dRC JAh+214scNbjAC1u5NE+Zb/N1Lh82rrkqkWg6/OZRaftiuwnRCgClD9UVXXYIfU7u8dA NRJUlbtBDnYMPv1+f8Y0LEgjPD0BQg3vbuM6X2P+sz7dC4LZWahY3gsZo0E7wFDxANzf 7MXQ== X-Gm-Message-State: ALKqPwc/4AsiXNtyWIW8XujPeekAJ72SBFXiZU7Mi46yXVamlyNRImvU QqYOcXHYTceKQmNunvSJE/0YhU6S X-Google-Smtp-Source: AB8JxZoXwF+f87TtkCeu7EXGzkRHWTWvE/vlJLzX9L8yckqXm9p13md1oUAU0Ds5huhnQkBrXXpSeg== X-Received: by 2002:aca:5f0b:: with SMTP id t11-v6mr13532962oib.103.1526959041146; Mon, 21 May 2018 20:17:21 -0700 (PDT) Received: from [10.8.8.11] ([173.254.254.30]) by smtp.gmail.com with ESMTPSA id v45-v6sm9499794otf.75.2018.05.21.20.17.20 for <mercurial-devel@mercurial-scm.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 May 2018 20:17:20 -0700 (PDT) MIME-Version: 1.0 Subject: [PATCH 2 of 5] githelp: cleanly abort if the `svn` command is unknown X-Mercurial-Node: c137053c30e3a477d9f27aa72f0f791d5bcbe5b2 X-Mercurial-Series-Index: 2 X-Mercurial-Series-Total: 5 Message-Id: <c137053c30e3a477d9f2.1526959029@Envy> X-Mercurial-Series-Id: <a34bed7475cc8237665a.1526959028@Envy> In-Reply-To: <a34bed7475cc8237665a.1526959028@Envy> References: <a34bed7475cc8237665a.1526959028@Envy> User-Agent: Mercurial-patchbomb/4.5.2 Date: Mon, 21 May 2018 23:17:09 -0400 From: Matt Harbison <mharbison72@gmail.com> To: mercurial-devel@mercurial-scm.org X-BeenThere: mercurial-devel@mercurial-scm.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <mercurial-devel.mercurial-scm.org> List-Unsubscribe: <https://www.mercurial-scm.org/mailman/options/mercurial-devel>, <mailto:mercurial-devel-request@mercurial-scm.org?subject=unsubscribe> List-Archive: <http://www.mercurial-scm.org/pipermail/mercurial-devel/> List-Post: <mailto:mercurial-devel@mercurial-scm.org> List-Help: <mailto:mercurial-devel-request@mercurial-scm.org?subject=help> List-Subscribe: <https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel>, <mailto:mercurial-devel-request@mercurial-scm.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org> |
Comments
Matt Harbison - May 22, 2018, 3:17 a.m.
Patch
diff --git a/hgext/githelp.py b/hgext/githelp.py --- a/hgext/githelp.py +++ b/hgext/githelp.py @@ -963,7 +963,7 @@ def svn(ui, repo, *args, **kwargs): raise error.Abort(_('missing svn command')) svncmd = args[0] if not svncmd in gitsvncommands: - ui.warn(_("error: unknown git svn command %s\n") % (svncmd)) + raise error.Abort(_('unknown git svn command "%s"') % (svncmd)) args = args[1:] return gitsvncommands[svncmd](ui, repo, *args, **kwargs)