Patchwork D3618: pathencode: remove unused variable

login
register
mail settings
Submitter phabricator
Date May 21, 2018, 6:39 p.m.
Message ID <1ef71ee8436dfce1a2530a8844812dfe@localhost.localdomain>
Download mbox | patch
Permalink /patch/31789/
State Not Applicable
Headers show

Comments

phabricator - May 21, 2018, 6:39 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf9eaa5cd9ee9: pathencode: remove unused variable (authored by durin42, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D3618?vs=8790&id=8861

REVISION DETAIL
  https://phab.mercurial-scm.org/D3618

AFFECTED FILES
  mercurial/cext/pathencode.c

CHANGE DETAILS




To: durin42, #hg-reviewers, indygreg
Cc: mercurial-devel

Patch

diff --git a/mercurial/cext/pathencode.c b/mercurial/cext/pathencode.c
--- a/mercurial/cext/pathencode.c
+++ b/mercurial/cext/pathencode.c
@@ -655,14 +655,7 @@ 
 	PyObject *shaobj, *hashobj;
 
 	if (shafunc == NULL) {
-		PyObject *hashlib, *name = PyBytes_FromString("hashlib");
-
-		if (name == NULL)
-			return -1;
-
-		hashlib = PyImport_ImportModule("hashlib");
-		Py_DECREF(name);
-
+		PyObject *hashlib = PyImport_ImportModule("hashlib");
 		if (hashlib == NULL) {
 			PyErr_SetString(PyExc_ImportError,
 			                "pathencode failed to find hashlib");