Patchwork D3486: convcmd: make a copy of heads before mutating it

login
register
mail settings
Submitter phabricator
Date May 8, 2018, 6:23 p.m.
Message ID <fdd76e1a61c4a034c184413f232b3ebc@localhost.localdomain>
Download mbox | patch
Permalink /patch/31393/
State Not Applicable
Headers show

Comments

phabricator - May 8, 2018, 6:23 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG73ca1c5e65f8: convcmd: make a copy of heads before mutating it (authored by durin42, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D3486?vs=8538&id=8561

REVISION DETAIL
  https://phab.mercurial-scm.org/D3486

AFFECTED FILES
  hgext/convert/convcmd.py

CHANGE DETAILS




To: durin42, #hg-reviewers, indygreg
Cc: mercurial-devel

Patch

diff --git a/hgext/convert/convcmd.py b/hgext/convert/convcmd.py
--- a/hgext/convert/convcmd.py
+++ b/hgext/convert/convcmd.py
@@ -234,7 +234,7 @@ 
     def walktree(self, heads):
         '''Return a mapping that identifies the uncommitted parents of every
         uncommitted changeset.'''
-        visit = heads
+        visit = list(heads)
         known = set()
         parents = {}
         numcommits = self.source.numcommits()