Patchwork D3486: convcmd: make a copy of heads before mutating it

login
register
mail settings
Submitter phabricator
Date May 8, 2018, 1:37 p.m.
Message ID <differential-rev-PHID-DREV-jc6u24qrl6qpdlyperw7-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/31364/
State Superseded
Headers show

Comments

phabricator - May 8, 2018, 1:37 p.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3486

AFFECTED FILES
  hgext/convert/convcmd.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/convert/convcmd.py b/hgext/convert/convcmd.py
--- a/hgext/convert/convcmd.py
+++ b/hgext/convert/convcmd.py
@@ -234,7 +234,7 @@ 
     def walktree(self, heads):
         '''Return a mapping that identifies the uncommitted parents of every
         uncommitted changeset.'''
-        visit = heads
+        visit = list(heads)
         known = set()
         parents = {}
         numcommits = self.source.numcommits()