Patchwork [3,of,4] bookmarks: make argument names of _set/_del() more specific

login
register
mail settings
Submitter Yuya Nishihara
Date May 6, 2018, 2:53 a.m.
Message ID <f8b12218af5c8d09da09.1525575226@mimosa>
Download mbox | patch
Permalink /patch/31274/
State Accepted
Headers show

Comments

Yuya Nishihara - May 6, 2018, 2:53 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1525488283 -32400
#      Sat May 05 11:44:43 2018 +0900
# Node ID f8b12218af5c8d09da0965d631ad6a19fc9df3de
# Parent  81ee88150e0e71017a099067dc164bd8b49071a2
bookmarks: make argument names of _set/_del() more specific

Patch

diff --git a/mercurial/bookmarks.py b/mercurial/bookmarks.py
--- a/mercurial/bookmarks.py
+++ b/mercurial/bookmarks.py
@@ -130,13 +130,13 @@  class bmstore(object):
     def get(self, mark, default=None):
         return self._refmap.get(mark, default)
 
-    def _set(self, key, value):
+    def _set(self, mark, node):
         self._clean = False
-        self._refmap[key] = value
+        self._refmap[mark] = node
 
-    def _del(self, key):
+    def _del(self, mark):
         self._clean = False
-        del self._refmap[key]
+        del self._refmap[mark]
 
     def names(self, node):
         """Return a sorted list of bookmarks pointing to the specified node"""