Patchwork [hglib] make: dist should also be a phony rule

login
register
mail settings
Submitter Augie Fackler
Date April 25, 2018, 5:32 p.m.
Message ID <9fef848282b9b8574f48.1524677569@augie-macbookpro2.roam.corp.google.com>
Download mbox | patch
Permalink /patch/31233/
State Accepted
Headers show

Comments

Augie Fackler - April 25, 2018, 5:32 p.m.
# HG changeset patch
# User Augie Fackler <raf@durin42.com>
# Date 1524677538 14400
#      Wed Apr 25 13:32:18 2018 -0400
# Node ID 9fef848282b9b8574f4897ca93390641647f4ad6
# Parent  5828b4483012dff82efacc0a6639de02b0c0b9dd
make: dist should also be a phony rule

Otherwise you have to blow away the dist/ dir before you can make a
new tarball.
Yuya Nishihara - April 26, 2018, 11:30 a.m.
On Wed, 25 Apr 2018 13:32:49 -0400, Augie Fackler wrote:
> # HG changeset patch
> # User Augie Fackler <raf@durin42.com>
> # Date 1524677538 14400
> #      Wed Apr 25 13:32:18 2018 -0400
> # Node ID 9fef848282b9b8574f4897ca93390641647f4ad6
> # Parent  5828b4483012dff82efacc0a6639de02b0c0b9dd
> make: dist should also be a phony rule

LGTM.

> diff --git a/Makefile b/Makefile
> --- a/Makefile
> +++ b/Makefile
> @@ -5,7 +5,7 @@ help:
>  
>  all: help
>  
> -.PHONY: tests
> +.PHONY: tests dist

+ all help
Augie Fackler - April 26, 2018, 4:54 p.m.
> On Apr 26, 2018, at 07:30, Yuya Nishihara <yuya@tcha.org> wrote:
> 
> On Wed, 25 Apr 2018 13:32:49 -0400, Augie Fackler wrote:
>> # HG changeset patch
>> # User Augie Fackler <raf@durin42.com>
>> # Date 1524677538 14400
>> #      Wed Apr 25 13:32:18 2018 -0400
>> # Node ID 9fef848282b9b8574f4897ca93390641647f4ad6
>> # Parent  5828b4483012dff82efacc0a6639de02b0c0b9dd
>> make: dist should also be a phony rule
> 
> LGTM.
> 
>> diff --git a/Makefile b/Makefile
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -5,7 +5,7 @@ help:
>> 
>> all: help
>> 
>> -.PHONY: tests
>> +.PHONY: tests dist
> 
> + all help

Pushing with those added, many thanks.

Patch

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -5,7 +5,7 @@  help:
 
 all: help
 
-.PHONY: tests
+.PHONY: tests dist
 
 MANIFEST.in:
 	hg manifest | sed -e 's/^/include /' > MANIFEST.in