Patchwork [Bug,5840] New: Infinitepush has missing bookmark issues on Windows

login
register
mail settings
Submitter mercurial-bugs@mercurial-scm.org
Date April 18, 2018, 4:39 a.m.
Message ID <bug-5840-285@https.bz.mercurial-scm.org/>
Download mbox | patch
Permalink /patch/31173/
State Not Applicable
Headers show

Comments

mercurial-bugs@mercurial-scm.org - April 18, 2018, 4:39 a.m.
https://bz.mercurial-scm.org/show_bug.cgi?id=5840

            Bug ID: 5840
           Summary: Infinitepush has missing bookmark issues on Windows
           Product: Mercurial
           Version: default branch
          Hardware: PC
                OS: Windows
            Status: UNCONFIRMED
          Severity: bug
          Priority: normal
         Component: Mercurial
          Assignee: bugzilla@mercurial-scm.org
          Reporter: matt_harbison@yahoo.com
                CC: 7895pulkit@gmail.com,
                    mercurial-devel@mercurial-scm.org

I'm trying to track down the test failures, and most seem to be aborts because
the remote bookmark is missing.  Here's a diff on Windows, against the output
where it works on Linux, with debugging output on.  Note the 'listkey for
"bookmarks"' went to 0 bytes on Windows.  The first line in the diff is a test
I added to list the bookmarks on the main repo.  (At least I think it is.  It
says no repo found if I drop $TESTTMP, but the other repos in that directory
are client{,2,3}.)  I'm not sure why it shows no bookmarks on both platforms.

$ hg diff
   adding testpullbycommithash1
-  created new head
   $ hg log -r '.' -T '{node}\n' > ../testpullbycommithash1
   $ echo testpullbycommithash2 > testpullbycommithash2
   $ hg ci -Aqm "testpullbycommithash2"

Patch

diff --git a/tests/test-infinitepush.t b/tests/test-infinitepush.t
--- a/tests/test-infinitepush.t
+++ b/tests/test-infinitepush.t
@@ -75,7 +75,7 @@  Pull two bookmarks from the second clien
   $ hg book -R $TESTTMP/repo
   no bookmarks set
   $ hg pull -B scratch/firstpart -B scratch/secondpart --debug
-  running python "/home/matt/hg/tests/dummyssh" 'user@dummy' 'hg -R repo serve
--stdio'
+  running python "c:\Users\Matt\projects\hg\tests/dummyssh" "user@dummy" "hg
-R repo serve --stdio"
   sending hello command
   sending between command
   remote: 436
@@ -84,58 +84,20 @@  Pull two bookmarks from the second clien
   sending protocaps command
   preparing listkeys for "bookmarks" with pattern "{'scratch/secondpart':
'REVTOFETCH', 'scratch/firstpart': 'REVTOFETCH'}"
   sending listkeyspatterns command
-  received listkey for "bookmarks": 118 bytes
-  pulling from ssh://user@dummy/repo
-  running python "/home/matt/hg/tests/dummyssh" 'user@dummy' 'hg -R repo serve
--stdio'
-  sending hello command
-  sending between command
-  remote: 436
-  remote: capabilities: batch branchmap
bundle2=HG20%0Ab2x%253Ainfinitepush%0Abookmarks%0Achangegroup%3D01%2C02%0Adigests%3Dmd5%2Csha1%2Csha512%0Aerror%3Dabort%2Cunsupportedcontent%2Cpushraced%2Cpushkey%0Ahgtagsfnodes%0Alistkeys%0Aphases%3Dheads%0Apushkey%0Aremote-changegroup%3Dhttp%2Chttps%0Arev-branch-cache
changegroupsubset getbundle known lookup protocaps pushkey
streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash
-  remote: 1
-  sending protocaps command
-  sending lookup command
-  sending lookup command
-  query 1; heads
-  sending batch command
-  searching for changes
-  all remote heads known locally
-  sending getbundle command
-  bundle2-input-bundle: with-transaction
-  bundle2-input-part: "changegroup" (params: 1 mandatory) supported
-  adding changesets
-  add changeset 8db3891c220e
-  adding manifests
-  adding file changes
-  adding scratchsecondpart revisions
-  added 1 changesets with 1 changes to 1 files
-  bundle2-input-part: total payload size 548
-  bundle2-input-part: "changegroup" (params: 1 mandatory) supported
-  adding changesets
-  add changeset 176993b87e39
-  adding manifests
-  adding file changes
-  adding scratchfirstpart revisions
-  added 1 changesets with 1 changes to 1 files (+1 heads)
-  bundle2-input-part: total payload size 543
-  bundle2-input-part: "listkeys" (params: 1 mandatory) supported
-  bundle2-input-part: "phase-heads" supported
-  bundle2-input-part: total payload size 48
-  bundle2-input-part: "cache:rev-branch-cache" supported
-  bundle2-input-bundle: 4 parts total
-  checking for updated bookmarks
-  updating the branch cache
-  new changesets * (glob)
-  (run 'hg heads' to see heads, 'hg merge' to merge)
+  received listkey for "bookmarks": 0 bytes
+  abort: remote bookmark scratch/secondpart not found!
+  [255]
   $ hg log -r scratch/secondpart -T '{node}'
-  8db3891c220e216f6da214e8254bd4371f55efca (no-eol)
+  abort: unknown revision 'scratch/secondpart'!
+  [255]
   $ hg log -r scratch/firstpart -T '{node}'
-  176993b87e39bd88d66a2cccadabe33f0b346339 (no-eol)
+  abort: unknown revision 'scratch/firstpart'!
+  [255]
 Make two commits to the scratch branch

   $ echo testpullbycommithash1 > testpullbycommithash1
   $ hg ci -Am "testpullbycommithash1"