Patchwork [1,of,5] test-lfs: add tests to force server error path coverage

login
register
mail settings
Submitter Yuya Nishihara
Date April 14, 2018, 7:28 a.m.
Message ID <20180414162849.a76f54d48c404c53e9fe8fc9@tcha.org>
Download mbox | patch
Permalink /patch/31005/
State New
Headers show

Comments

Yuya Nishihara - April 14, 2018, 7:28 a.m.
On Fri, 13 Apr 2018 18:04:33 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison <matt_harbison@yahoo.com>
> # Date 1523119701 14400
> #      Sat Apr 07 12:48:21 2018 -0400
> # Node ID 1d394ac0efd4aa4f61f428fbac140fe57398f0b8
> # Parent  bfdd20d22a86edc318493b4da84a1d7ff4ef98f2
> test-lfs: add tests to force server error path coverage

The test failed on my machine. Can you take a look?



ERROR: test-lfs-serve-access.t output changed
!
Failed test-lfs-serve-access.t: output changed
# Ran 1 tests, 0 skipped, 1 failed.
python hash seed: 3873177365
Matt Harbison - April 14, 2018, 6:11 p.m.
On Sat, 14 Apr 2018 03:28:49 -0400, Yuya Nishihara <yuya@tcha.org> wrote:

> On Fri, 13 Apr 2018 18:04:33 -0400, Matt Harbison wrote:
>> # HG changeset patch
>> # User Matt Harbison <matt_harbison@yahoo.com>
>> # Date 1523119701 14400
>> #      Sat Apr 07 12:48:21 2018 -0400
>> # Node ID 1d394ac0efd4aa4f61f428fbac140fe57398f0b8
>> # Parent  bfdd20d22a86edc318493b4da84a1d7ff4ef98f2
>> test-lfs: add tests to force server error path coverage
>
> The test failed on my machine. Can you take a look?

It crossed paths with 330ada7e8ea5.  Will resend.

Patch

--- /home/yuya/work/hghacks/mercurial-review/tests/test-lfs-serve-access.t
+++ /home/yuya/work/hghacks/mercurial-review/tests/test-lfs-serve-access.t.err
@@ -270,14 +270,12 @@ 
   $LOCALIP - - [$LOGDATE$] "GET /?cmd=listkeys HTTP/1.1" 200 - x-hgarg-1:namespace=phases x-hgproto-1:0.1 0.2 comp=$USUAL_COMPRESSIONS$ partial-pull (glob)
   $LOCALIP - - [$LOGDATE$] "GET /?cmd=listkeys HTTP/1.1" 200 - x-hgarg-1:namespace=bookmarks x-hgproto-1:0.1 0.2 comp=$USUAL_COMPRESSIONS$ partial-pull (glob)
   $LOCALIP - - [$LOGDATE$] "GET /?cmd=branchmap HTTP/1.1" 200 - x-hgproto-1:0.1 0.2 comp=$USUAL_COMPRESSIONS$ partial-pull (glob)
-  $LOCALIP - - [$LOGDATE$] "GET /?cmd=branchmap HTTP/1.1" 200 - x-hgproto-1:0.1 0.2 comp=$USUAL_COMPRESSIONS$ partial-pull (glob)
   $LOCALIP - - [$LOGDATE$] "GET /?cmd=listkeys HTTP/1.1" 200 - x-hgarg-1:namespace=bookmarks x-hgproto-1:0.1 0.2 comp=$USUAL_COMPRESSIONS$ partial-pull (glob)
   $LOCALIP - - [$LOGDATE$] "POST /.git/info/lfs/objects/batch HTTP/1.1" 200 - (glob)
   $LOCALIP - - [$LOGDATE$] "GET /?cmd=capabilities HTTP/1.1" 200 - (glob)
   $LOCALIP - - [$LOGDATE$] "GET /?cmd=batch HTTP/1.1" 200 - x-hgarg-1:cmds=heads+%3Bknown+nodes%3D392c05922088bacf8e68a6939b480017afbf245d x-hgproto-1:0.1 0.2 comp=$USUAL_COMPRESSIONS$ partial-pull (glob)
   $LOCALIP - - [$LOGDATE$] "GET /?cmd=listkeys HTTP/1.1" 200 - x-hgarg-1:namespace=phases x-hgproto-1:0.1 0.2 comp=$USUAL_COMPRESSIONS$ partial-pull (glob)
   $LOCALIP - - [$LOGDATE$] "GET /?cmd=listkeys HTTP/1.1" 200 - x-hgarg-1:namespace=bookmarks x-hgproto-1:0.1 0.2 comp=$USUAL_COMPRESSIONS$ partial-pull (glob)
-  $LOCALIP - - [$LOGDATE$] "GET /?cmd=branchmap HTTP/1.1" 200 - x-hgproto-1:0.1 0.2 comp=$USUAL_COMPRESSIONS$ partial-pull (glob)
   $LOCALIP - - [$LOGDATE$] "GET /?cmd=branchmap HTTP/1.1" 200 - x-hgproto-1:0.1 0.2 comp=$USUAL_COMPRESSIONS$ partial-pull (glob)
   $LOCALIP - - [$LOGDATE$] "GET /?cmd=listkeys HTTP/1.1" 200 - x-hgarg-1:namespace=bookmarks x-hgproto-1:0.1 0.2 comp=$USUAL_COMPRESSIONS$ partial-pull (glob)
   $LOCALIP - - [$LOGDATE$] "POST /.git/info/lfs/objects/batch HTTP/1.1" 200 - (glob)