Patchwork D3332: httppeer: handle error response from client reactor

login
register
mail settings
Submitter phabricator
Date April 13, 2018, 9:37 p.m.
Message ID <differential-rev-PHID-DREV-6oc7kfe3mynx3xyhq7ye-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/30896/
State Superseded
Headers show

Comments

phabricator - April 13, 2018, 9:37 p.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  With this in place, we're now seeing useful errors when running
  tests with the new wire protocol enabled!

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3332

AFFECTED FILES
  mercurial/httppeer.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/httppeer.py b/mercurial/httppeer.py
--- a/mercurial/httppeer.py
+++ b/mercurial/httppeer.py
@@ -763,6 +763,14 @@ 
                     f.set_result(result)
                     del results[request.requestid]
 
+            elif action == 'error':
+                e = error.RepoError(meta['message'])
+
+                if f:
+                    f.set_exception(e)
+                else:
+                    raise e
+
             else:
                 e = error.ProgrammingError('unhandled action: %s' % action)