Patchwork D3328: py3: use b"%d" instead of str() to convert int to bytes

login
register
mail settings
Submitter phabricator
Date April 13, 2018, 8:48 p.m.
Message ID <differential-rev-PHID-DREV-7b4tioas3ecvz7vfxoaf-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/30890/
State Superseded
Headers show

Comments

phabricator - April 13, 2018, 8:48 p.m.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  While I was here, I added 'and None' to suppress return values of .write()
  calls.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3328

AFFECTED FILES
  tests/test-clone-uncompressed.t

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/test-clone-uncompressed.t b/tests/test-clone-uncompressed.t
--- a/tests/test-clone-uncompressed.t
+++ b/tests/test-clone-uncompressed.t
@@ -18,7 +18,7 @@ 
   $ hg -q commit -A -m initial
   >>> for i in range(1024):
   ...     with open(str(i), 'wb') as fh:
-  ...         fh.write(str(i))
+  ...         fh.write(b"%d" % i) and None
   $ hg -q commit -A -m 'add a lot of files'
   $ hg st
   $ hg --config server.uncompressed=false serve -p $HGPORT -d --pid-file=hg.pid