Patchwork D3274: py3: make sure we open file in bytes mode

login
register
mail settings
Submitter phabricator
Date April 12, 2018, 3:04 p.m.
Message ID <82687bbea45b207fd0996259c9360278@localhost.localdomain>
Download mbox | patch
Permalink /patch/30786/
State Not Applicable
Headers show

Comments

phabricator - April 12, 2018, 3:04 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6ef94f24aa82: py3: make sure we open file in bytes mode (authored by pulkit, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D3274?vs=8041&id=8054

REVISION DETAIL
  https://phab.mercurial-scm.org/D3274

AFFECTED FILES
  mercurial/sparse.py

CHANGE DETAILS




To: pulkit, #hg-reviewers, indygreg
Cc: mercurial-devel

Patch

diff --git a/mercurial/sparse.py b/mercurial/sparse.py
--- a/mercurial/sparse.py
+++ b/mercurial/sparse.py
@@ -579,7 +579,7 @@ 
         # part of the active rules.
         changed = False
         for p in paths:
-            with util.posixfile(util.expandpath(p)) as fh:
+            with util.posixfile(util.expandpath(p), mode='rb') as fh:
                 raw = fh.read()
 
             iincludes, iexcludes, iprofiles = parseconfig(repo.ui, raw)