Patchwork D3285: py3: use bytes() instead of str() on util.url()

login
register
mail settings
Submitter phabricator
Date April 12, 2018, 12:08 p.m.
Message ID <differential-rev-PHID-DREV-nixkqzjt25hv3t22jlzx-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/30784/
State Superseded
Headers show

Comments

phabricator - April 12, 2018, 12:08 p.m.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  We internally deal with bytes and anything as string breaks things.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3285

AFFECTED FILES
  mercurial/subrepoutil.py

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/subrepoutil.py b/mercurial/subrepoutil.py
--- a/mercurial/subrepoutil.py
+++ b/mercurial/subrepoutil.py
@@ -106,7 +106,7 @@ 
                 parent = util.url(parent)
                 parent.path = posixpath.join(parent.path or '', src)
                 parent.path = posixpath.normpath(parent.path)
-                joined = str(parent)
+                joined = bytes(parent)
                 # Remap the full joined path and use it if it changes,
                 # else remap the original source.
                 remapped = remap(joined)