Patchwork D3157: histedit: drop unnecessary check for "self.node is not None"

login
register
mail settings
Submitter phabricator
Date April 10, 2018, 4:03 p.m.
Message ID <71540d823501d1bb0216464da9878325@localhost.localdomain>
Download mbox | patch
Permalink /patch/30640/
State Not Applicable
Headers show

Comments

phabricator - April 10, 2018, 4:03 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG966061b8826d: histedit: drop unnecessary check for &quot;self.node is not None&quot; (authored by martinvonz, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D3157?vs=7782&id=7935

REVISION DETAIL
  https://phab.mercurial-scm.org/D3157

AFFECTED FILES
  hgext/histedit.py

CHANGE DETAILS




To: martinvonz, durin42, #hg-reviewers, indygreg
Cc: mercurial-devel

Patch

diff --git a/hgext/histedit.py b/hgext/histedit.py
--- a/hgext/histedit.py
+++ b/hgext/histedit.py
@@ -448,8 +448,7 @@ 
         except error.RepoError:
             raise error.ParseError(_('unknown changeset %s listed')
                               % ha[:12])
-        if self.node is not None:
-            self._verifynodeconstraints(prev, expected, seen)
+        self._verifynodeconstraints(prev, expected, seen)
 
     def _verifynodeconstraints(self, prev, expected, seen):
         # by default command need a node in the edited list