D3214: py3: use .startswith() instead of bytes[0]

Submitter	phabricator
Date	April 10, 2018, 2:15 p.m.
Message ID	<differential-rev-PHID-DREV-cfoxpgaac74p7twcdsiz-req@phab.mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/30623/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Tue, 10 Apr 2018 14:15:01 +0000 To: mercurial-devel@mercurial-scm.org From: "pulkit (Pulkit Goyal)" <phabricator@mercurial-scm.org> Subject: D3214: py3: use .startswith() instead of bytes[0] Message-ID: <differential-rev-PHID-DREV-cfoxpgaac74p7twcdsiz-req@phab.mercurial-scm.org> Thread-Topic: D3214: py3: use .startswith() instead of bytes[0] Precedence: bulk Thread-Index: NTY0MTMzYmJlYjcxMGNmZDVmMTczY2ZkYmUz MIME-Version: 1.0 Reply-To: phabricator+D3214+public+29b76226b8bbb7e2@mercurial-scm.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - April 10, 2018, 2:15 p.m.

pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3214

AFFECTED FILES
  hgext/mq.py

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/mq.py b/hgext/mq.py
--- a/hgext/mq.py
+++ b/hgext/mq.py
@@ -658,10 +658,11 @@ 
         if not patchguards:
             return True, None
         guards = self.active()
-        exactneg = [g for g in patchguards if g[0] == '-' and g[1:] in guards]
+        exactneg = [g for g in patchguards
+                    if g.startswith('-') and g[1:] in guards]
         if exactneg:
             return False, repr(exactneg[0])
-        pos = [g for g in patchguards if g[0] == '+']
+        pos = [g for g in patchguards if g.startswith('+')]
         exactpos = [g for g in pos if g[1:] in guards]
         if pos:
             if exactpos:

Patchwork D3214: py3: use .startswith() instead of bytes[0]

Comments

Patch