Patchwork D3199: util: drop write_content_size=True

login
register
mail settings
Submitter phabricator
Date April 9, 2018, 10:37 p.m.
Message ID <1b8c286c9f9bf125c00991e3892b52d0@localhost.localdomain>
Download mbox | patch
Permalink /patch/30616/
State Not Applicable
Headers show

Comments

phabricator - April 9, 2018, 10:37 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1765ed63db40: util: drop write_content_size=True (authored by indygreg, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D3199?vs=7903&id=7918

REVISION DETAIL
  https://phab.mercurial-scm.org/D3199

AFFECTED FILES
  mercurial/util.py

CHANGE DETAILS




To: indygreg, #hg-reviewers, durin42
Cc: mercurial-devel

Patch

diff --git a/mercurial/util.py b/mercurial/util.py
--- a/mercurial/util.py
+++ b/mercurial/util.py
@@ -3566,11 +3566,11 @@ 
 
     class zstdrevlogcompressor(object):
         def __init__(self, zstd, level=3):
-            # Writing the content size adds a few bytes to the output. However,
-            # it allows decompression to be more optimal since we can
-            # pre-allocate a buffer to hold the result.
-            self._cctx = zstd.ZstdCompressor(level=level,
-                                             write_content_size=True)
+            # TODO consider omitting frame magic to save 4 bytes.
+            # This writes content sizes into the frame header. That is
+            # extra storage. But it allows a correct size memory allocation
+            # to hold the result.
+            self._cctx = zstd.ZstdCompressor(level=level)
             self._dctx = zstd.ZstdDecompressor()
             self._compinsize = zstd.COMPRESSION_RECOMMENDED_INPUT_SIZE
             self._decompinsize = zstd.DECOMPRESSION_RECOMMENDED_INPUT_SIZE