Patchwork [4,of,5] tests: quote variable passed to shell test command

login
register
mail settings
Submitter Yuya Nishihara
Date April 8, 2018, 8:59 a.m.
Message ID <8aa9c24cdfed32a38e77.1523177984@mimosa>
Download mbox | patch
Permalink /patch/30555/
State Accepted
Headers show

Comments

Yuya Nishihara - April 8, 2018, 8:59 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1523158259 -32400
#      Sun Apr 08 12:30:59 2018 +0900
# Node ID 8aa9c24cdfed32a38e777474f6d5e6652de7dc28
# Parent  9a35569ef5ab58c975f56ecb063a1b82b25ec6b8
tests: quote variable passed to shell test command

Patch

diff --git a/tests/helpers-testrepo.sh b/tests/helpers-testrepo.sh
--- a/tests/helpers-testrepo.sh
+++ b/tests/helpers-testrepo.sh
@@ -10,7 +10,7 @@ 
 # system mercurial installation, and may require extensions or settings from
 # the system installation.
 
-if [ -n $HGTESTEXTRAEXTENSIONS ]; then
+if [ -n "$HGTESTEXTRAEXTENSIONS" ]; then
     for extension in $HGTESTEXTRAEXTENSIONS; do
         extraoptions="$extraoptions --config extensions.$extension=!"
     done