Patchwork D3157: histedit: drop unnecessary check for "self.node is not None"

login
register
mail settings
Submitter phabricator
Date April 6, 2018, 4:54 p.m.
Message ID <differential-rev-PHID-DREV-odmv7xnduyfr3rm55geb-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/30439/
State Superseded
Headers show

Comments

phabricator - April 6, 2018, 4:54 p.m.
martinvonz created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  We are doing hex(self.node) just a few lines up, so it shouldn't be
  None. The only way it could be none is if it was reassigned in
  between. The only way that can happen is if the user had put a
  "ffff..." wdirhex revision in the histedit script. This code is much
  older than the "ffff..." identifier, so I'm confident it's not there
  to handle that case. I'll let someone else add proper checks for
  "ffff..." if they care enough.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3157

AFFECTED FILES
  hgext/histedit.py

CHANGE DETAILS




To: martinvonz, durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/histedit.py b/hgext/histedit.py
--- a/hgext/histedit.py
+++ b/hgext/histedit.py
@@ -448,8 +448,7 @@ 
         except error.RepoError:
             raise error.ParseError(_('unknown changeset %s listed')
                               % ha[:12])
-        if self.node is not None:
-            self._verifynodeconstraints(prev, expected, seen)
+        self._verifynodeconstraints(prev, expected, seen)
 
     def _verifynodeconstraints(self, prev, expected, seen):
         # by default command need a node in the edited list