D3142: narrow: remove unused "cacheprop" stuff

Submitter	phabricator
Date	April 5, 2018, 7:42 p.m.
Message ID	<differential-rev-PHID-DREV-3ldb26uquxfchmnrvq6t-req@phab.mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/30406/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Thu, 5 Apr 2018 19:42:24 +0000 To: mercurial-devel@mercurial-scm.org From: "martinvonz (Martin von Zweigbergk)" <phabricator@mercurial-scm.org> Subject: D3142: narrow: remove unused "cacheprop" stuff Message-ID: <differential-rev-PHID-DREV-3ldb26uquxfchmnrvq6t-req@phab.mercurial-scm.org> Thread-Topic: D3142: narrow: remove unused "cacheprop" stuff Precedence: bulk Thread-Index: OTlmZGMwMzUxNGRkMWRmMDhjMjQwMzQ3MDMy MIME-Version: 1.0 Reply-To: phabricator+D3142+public+c972f570e9106346@mercurial-scm.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - April 5, 2018, 7:42 p.m.

martinvonz created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  This is unused since https://phab.mercurial-scm.org/D3046. I didn't even notice it then, but tests
  still pass so I hope it's still handled safely.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3142

AFFECTED FILES
  hgext/narrow/narrowrepo.py

CHANGE DETAILS




To: martinvonz, durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/narrow/narrowrepo.py b/hgext/narrow/narrowrepo.py
--- a/hgext/narrow/narrowrepo.py
+++ b/hgext/narrow/narrowrepo.py
@@ -8,10 +8,8 @@ 
 from __future__ import absolute_import
 
 from mercurial import (
-    bundlerepo,
     changegroup,
     hg,
-    localrepo,
     narrowspec,
     scmutil,
 )
@@ -40,14 +38,6 @@ 
 def wraprepo(repo):
     """Enables narrow clone functionality on a single local repository."""
 
-    cacheprop = localrepo.storecache
-    if isinstance(repo, bundlerepo.bundlerepository):
-        # We have to use a different caching property decorator for
-        # bundlerepo because storecache blows up in strange ways on a
-        # bundlerepo. Fortunately, there's no risk of data changing in
-        # a bundlerepo.
-        cacheprop = lambda name: localrepo.unfilteredpropertycache
-
     class narrowrepository(repo.__class__):
 
         def file(self, f):

Patchwork D3142: narrow: remove unused "cacheprop" stuff

Comments

Patch