Patchwork D3128: py3: suppress the output of open() using `and None`

login
register
mail settings
Submitter phabricator
Date April 5, 2018, 12:31 p.m.
Message ID <differential-rev-PHID-DREV-aonu2qikc462elrymiow-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/30354/
State Superseded
Headers show

Comments

phabricator - April 5, 2018, 12:31 p.m.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  This patch suppresses the output of open() on Python 3 as it does not return any
  output on Python 2.
  
  This makes test-diffstat.t pass on Python 3.5

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3128

AFFECTED FILES
  tests/test-diffstat.t

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/test-diffstat.t b/tests/test-diffstat.t
--- a/tests/test-diffstat.t
+++ b/tests/test-diffstat.t
@@ -35,7 +35,7 @@ 
 
   $ hg ci -m appenda
 
-  >>> open("c", "wb").write(b"\0")
+  >>> open("c", "wb").write(b"\0") and None
   $ touch d
   $ hg add c d
 
@@ -54,7 +54,7 @@ 
 
   $ hg ci -m createb
 
-  >>> open("file with spaces", "wb").write(b"\0")
+  >>> open("file with spaces", "wb").write(b"\0") and None
   $ hg add "file with spaces"
 
 Filename with spaces diffstat: