Patchwork [1,of,7] phases: add a formal note that hash of secret changeset may leak out

login
register
mail settings
Submitter Pierre-Yves David
Date Nov. 17, 2013, 8:31 p.m.
Message ID <2f303c30177f75adf0d9.1384720300@vulgaris>
Download mbox | patch
Permalink /patch/3029/
State Superseded
Headers show

Comments

Pierre-Yves David - Nov. 17, 2013, 8:31 p.m.
# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
# Date 1384705817 18000
#      Sun Nov 17 11:30:17 2013 -0500
# Node ID 2f303c30177f75adf0d9f97955504e0938752fa4
# Parent  6c1adf2067bb7c225f96cf253e9e228b5a7cdcf4
phases: add a formal note that hash of secret changeset may leak out

For technical reason (discovery, obsolescence marker) the hash of secret
changeset are communicated outside of your repo. We clarifie that in the help so
that people does not used hash of secret changeset as nuclear launch code.
Didly - Nov. 17, 2013, 8:38 p.m.
On Sun, Nov 17, 2013 at 9:31 PM,  <pierre-yves.david@ens-lyon.org> wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
> # Date 1384705817 18000
> #      Sun Nov 17 11:30:17 2013 -0500
> # Node ID 2f303c30177f75adf0d9f97955504e0938752fa4
> # Parent  6c1adf2067bb7c225f96cf253e9e228b5a7cdcf4
> phases: add a formal note that hash of secret changeset may leak out
>
> For technical reason (discovery, obsolescence marker) the hash of secret
> changeset are communicated outside of your repo. We clarifie that in the help so
> that people does not used hash of secret changeset as nuclear launch code.
>
> diff --git a/mercurial/help/phases.txt b/mercurial/help/phases.txt
> --- a/mercurial/help/phases.txt
> +++ b/mercurial/help/phases.txt
> @@ -56,10 +56,16 @@ See :hg:`help config` for more informati
>
>  .. note::
>    Servers running older versions of Mercurial are treated as
>    publishing.
>
> +.. note::
> +    Changesets in secret phase are not exchanged the secret. This applies to
> +    they content: files name, files content and changeset metadata. For
> +    technical reason, the hash of secret changeset may be communicated to the
> +    server.

I think I get the gist of what you want to say here but I am not 100%
sure. What do you mean by "Changesets in secret phase are not
exchanged the secret"?

Also, it should be "This applies to theIR content" and probably "for
technical reasonS".

Cheers,

Angel
Pierre-Yves David - Nov. 27, 2013, 6:18 p.m.
On 11/17/2013 12:38 PM, Didly wrote:
> On Sun, Nov 17, 2013 at 9:31 PM,  <pierre-yves.david@ens-lyon.org> wrote:
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
>> # Date 1384705817 18000
>> #      Sun Nov 17 11:30:17 2013 -0500
>> # Node ID 2f303c30177f75adf0d9f97955504e0938752fa4
>> # Parent  6c1adf2067bb7c225f96cf253e9e228b5a7cdcf4
>> phases: add a formal note that hash of secret changeset may leak out
>>
>> For technical reason (discovery, obsolescence marker) the hash of secret
>> changeset are communicated outside of your repo. We clarifie that in the help so
>> that people does not used hash of secret changeset as nuclear launch code.
>>
>> diff --git a/mercurial/help/phases.txt b/mercurial/help/phases.txt
>> --- a/mercurial/help/phases.txt
>> +++ b/mercurial/help/phases.txt
>> @@ -56,10 +56,16 @@ See :hg:`help config` for more informati
>>
>>   .. note::
>>     Servers running older versions of Mercurial are treated as
>>     publishing.
>>
>> +.. note::
>> +    Changesets in secret phase are not exchanged the secret. This applies to
>> +    they content: files name, files content and changeset metadata. For
>> +    technical reason, the hash of secret changeset may be communicated to the
>> +    server.
> I think I get the gist of what you want to say here but I am not 100%
> sure. What do you mean by "Changesets in secret phase are not
> exchanged the secret"?

New fixed version is:

   Changesets in secret phase are not exchanged with server. This applies to
   their content: files name, files content and changeset metadata. For
   technical reasons, the identifier (eg d825e4025e39) of secret 
changeset may
   be communicated to the server.

Let me know if anything is still confusing or misspelled.
Sean Farley - Nov. 27, 2013, 8:27 p.m.
pierre-yves.david@ens-lyon.org writes:

> On 11/17/2013 12:38 PM, Didly wrote:
>> On Sun, Nov 17, 2013 at 9:31 PM,  <pierre-yves.david@ens-lyon.org> wrote:
>>> # HG changeset patch
>>> # User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
>>> # Date 1384705817 18000
>>> #      Sun Nov 17 11:30:17 2013 -0500
>>> # Node ID 2f303c30177f75adf0d9f97955504e0938752fa4
>>> # Parent  6c1adf2067bb7c225f96cf253e9e228b5a7cdcf4
>>> phases: add a formal note that hash of secret changeset may leak out
>>>
>>> For technical reason (discovery, obsolescence marker) the hash of secret
>>> changeset are communicated outside of your repo. We clarifie that in the help so
>>> that people does not used hash of secret changeset as nuclear launch code.
>>>
>>> diff --git a/mercurial/help/phases.txt b/mercurial/help/phases.txt
>>> --- a/mercurial/help/phases.txt
>>> +++ b/mercurial/help/phases.txt
>>> @@ -56,10 +56,16 @@ See :hg:`help config` for more informati
>>>
>>>   .. note::
>>>     Servers running older versions of Mercurial are treated as
>>>     publishing.
>>>
>>> +.. note::
>>> +    Changesets in secret phase are not exchanged the secret. This applies to
>>> +    they content: files name, files content and changeset metadata. For
>>> +    technical reason, the hash of secret changeset may be communicated to the
>>> +    server.
>> I think I get the gist of what you want to say here but I am not 100%
>> sure. What do you mean by "Changesets in secret phase are not
>> exchanged the secret"?
>
> New fixed version is:
>
>    Changesets in secret phase are not exchanged with server. This applies to
>    their content: files name, files content and changeset metadata. For
>    technical reasons, the identifier (eg d825e4025e39) of secret 
> changeset may
>    be communicated to the server.
>
> Let me know if anything is still confusing or misspelled.

I would tweak it a little more:

   Changesets in secret phase are not exchanged with the server. This
   applies to their content: file names, file contents, and changeset
   metadata. For technical reasons, the identifier (e.g. d825e4025e39)
   of the secret changeset may be communicated to the server.

Patch

diff --git a/mercurial/help/phases.txt b/mercurial/help/phases.txt
--- a/mercurial/help/phases.txt
+++ b/mercurial/help/phases.txt
@@ -56,10 +56,16 @@  See :hg:`help config` for more informati
 
 .. note::
   Servers running older versions of Mercurial are treated as
   publishing.
 
+.. note::
+    Changesets in secret phase are not exchanged the secret. This applies to
+    they content: files name, files content and changeset metadata. For
+    technical reason, the hash of secret changeset may be communicated to the
+    server.
+
 Examples
 ========
 
  - list changesets in draft or secret phase::