Patchwork D3056: tests: disable test-revlog-v2 when using simple store

login
register
mail settings
Submitter phabricator
Date April 4, 2018, 1:57 a.m.
Message ID <differential-rev-PHID-DREV-xkcg7d77kpnrnbdpags2-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/30230/
State Superseded
Headers show

Comments

phabricator - April 4, 2018, 1:57 a.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Because the simple store has nothing to do with revlogs.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3056

AFFECTED FILES
  tests/test-revlog-v2.t

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel
phabricator - April 4, 2018, 6:12 p.m.
durin42 added a comment.


  Though I do wonder if this should be a positive check, that is, "require it's on revlogs" rather than "require it's not on the simple store"?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3056

To: indygreg, #hg-reviewers, durin42
Cc: mercurial-devel
phabricator - April 4, 2018, 6:31 p.m.
indygreg added a comment.


  In https://phab.mercurial-scm.org/D3056#49554, @durin42 wrote:
  
  > Though I do wonder if this should be a positive check, that is, "require it's on revlogs" rather than "require it's not on the simple store"?
  
  
  Yes, it should. Will re-submit.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3056

To: indygreg, #hg-reviewers, durin42
Cc: mercurial-devel

Patch

diff --git a/tests/test-revlog-v2.t b/tests/test-revlog-v2.t
--- a/tests/test-revlog-v2.t
+++ b/tests/test-revlog-v2.t
@@ -1,3 +1,5 @@ 
+#require no-reposimplestore
+
 A repo with unknown revlogv2 requirement string cannot be opened
 
   $ hg init invalidreq