Patchwork D3049: bundle: consistently keep a list of stringified revisions in "revs"

login
register
mail settings
Submitter phabricator
Date April 3, 2018, 10:09 p.m.
Message ID <differential-rev-PHID-DREV-kn4a3jy5uow72lfxvyrh-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/30216/
State Superseded
Headers show

Comments

phabricator - April 3, 2018, 10:09 p.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Before this patch, "revs", in the "not base" branch, would be a list
  of mixed integral revnums, hex nodeids, and branch names. After this
  patch, they're all strings. They can still be a mix of hex nodeids and
  branch names, but the important thing for my future patches is that
  they're consistently in string form.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3049

AFFECTED FILES
  mercurial/commands.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/commands.py b/mercurial/commands.py
--- a/mercurial/commands.py
+++ b/mercurial/commands.py
@@ -1231,6 +1231,7 @@ 
         dest = ui.expandpath(dest or 'default-push', dest or 'default')
         dest, branches = hg.parseurl(dest, opts.get('branch'))
         other = hg.peer(repo, opts, dest)
+        revs = [repo[r].hex() for r in revs]
         revs, checkout = hg.addbranchrevs(repo, repo, branches, revs)
         heads = revs and map(repo.lookup, revs) or revs
         outgoing = discovery.findcommonoutgoing(repo, other,